Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geoplatform link section #178

Merged
merged 17 commits into from
Dec 11, 2023
Merged

Add geoplatform link section #178

merged 17 commits into from
Dec 11, 2023

Conversation

rshewitt
Copy link
Contributor

@rshewitt rshewitt commented Dec 8, 2023 •
edited
Loading

related to #3478

  • add "other data resource" section on dataset page
  • adds geoplatform link fetcher function as fanstatic script
  • add cypress tests checking visibility/invisibility of section
  • bump pypi version

TODO:

@rshewitt rshewitt requested a review from FuhuXia December 8, 2023 18:28
@FuhuXia
Copy link
Member

FuhuXia commented Dec 8, 2023

can we have a visual, such as a screenshot or catalog-dev live demo?

@rshewitt
Copy link
Contributor Author

rshewitt commented Dec 8, 2023 •
edited
Loading

can we have a visual, such as a screenshot or catalog-dev live demo?

Screenshot 2023-12-08 at 1 24 32 PM

This is available on dev but you need to go to the element and remove the hide class attribute

@rshewitt rshewitt requested a review from FuhuXia December 11, 2023 16:35
@rshewitt rshewitt merged commit 62935c6 into main Dec 11, 2023
4 checks passed
@rshewitt rshewitt deleted the add-geoplatform-link branch December 11, 2023 19:45
@rshewitt rshewitt restored the add-geoplatform-link branch December 13, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btylerburton btylerburton btylerburton approved these changes

@FuhuXia FuhuXia Awaiting requested review from FuhuXia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rshewitt @FuhuXia @btylerburton