Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dataset bottom margin #174

Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix dataset bottom margin #174

merged 3 commits into from
Nov 28, 2023

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Nov 28, 2023 •
edited
Loading

For GSA/data.gov#4410

  • reduced bottom margin in resources
  • added padding in dataset-item
  • added border to match vanilla ckan style

Before:

image

After:

image

Before:

image

After:

image

FuhuXia added a commit to GSA/catalog.data.gov that referenced this pull request Nov 28, 2023
@FuhuXia
Update requirements.txt for datagovtheme margin fix
b6b28fe 
Bring changes from GSA/ckanext-datagovtheme#174
@FuhuXia FuhuXia requested a review from a team November 28, 2023 17:38
@FuhuXia FuhuXia mentioned this pull request Nov 28, 2023
Merged
@Jin-Sun-tts Jin-Sun-tts merged commit 3fce9b1 into main Nov 28, 2023
4 checks passed
@Jin-Sun-tts Jin-Sun-tts deleted the fix-margin branch November 28, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jin-Sun-tts Jin-Sun-tts Jin-Sun-tts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FuhuXia @Jin-Sun-tts