Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[75] Assign Evaluators to a Submission #329

Merged
merged 57 commits into from
Jan 8, 2025

Conversation

stonefilipczak
Copy link
Contributor

@stonefilipczak stonefilipczak commented Dec 20, 2024

Assigns and unassigns evaluators to a submission via the submission details page.

WAVE:
Screen Shot 2025-01-07 at 11 55 29 AM

@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/31/24 milestone Dec 20, 2024
@r-bartlett-gsa r-bartlett-gsa linked an issue Dec 20, 2024 that may be closed by this pull request
49 tasks
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback

app/helpers/submissions_helper.rb Outdated Show resolved Hide resolved
app/views/submissions/_available_evaluators.html.erb Outdated Show resolved Hide resolved
app/views/submissions/_available_evaluators.html.erb Outdated Show resolved Hide resolved
app/views/submissions/_available_evaluators.html.erb Outdated Show resolved Hide resolved
app/views/submissions/_assigned_evaluators.html.erb Outdated Show resolved Hide resolved
spec/system/submission_details_spec.rb Outdated Show resolved Hide resolved
spec/system/submission_details_spec.rb Outdated Show resolved Hide resolved
Comment on lines +69 to +73
click_on('Assign')
expect(page).to have_css("p.usa-alert__text", text: "Evaluator assigned successfully")

click_on('Unassign')
expect(page).to have_css("p.usa-alert__text", text: "Evaluator unassigned successfully")
Copy link
Contributor

@stepchud stepchud Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this would test a specific evaluator is assigned and unassigned, and they show up on the correct table in the view

app/views/submissions/_available_evaluators.html.erb Outdated Show resolved Hide resolved
@stepchud stepchud changed the title [75] Assign Evaluators to a Submission (WIP) [75] Assign Evaluators to a Submission Jan 7, 2025
@stepchud stepchud removed the WIP label Jan 7, 2025
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile layout

app/views/submissions/_submission_evaluation.html.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@stonefilipczak stonefilipczak merged commit 5baef9a into dev Jan 8, 2025
11 checks passed
@stonefilipczak stonefilipczak deleted the 75_evaluator_submission_assignment branch January 8, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign Evaluators to a Submission - Manual
3 participants