Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[52, 53, 126] Dashboard Component / Challenge Manager's Dashboard / Evaluator's Dashboard #136

Merged
merged 55 commits into from
Sep 16, 2024
Merged

[52, 53, 126] Dashboard Component / Challenge Manager's Dashboard / Evaluator's Dashboard #136

merged 55 commits into from
Sep 16, 2024

Conversation

stonefilipczak
Copy link
Contributor

@stonefilipczak stonefilipczak commented Aug 30, 2024 •
edited
Loading

Creates a re-usable dashboard component which can be customized for different user roles.

Challenge Manager:
Screen Shot 2024-09-10 at 10 13 30 AM
Screen Shot 2024-09-10 at 10 13 46 AM

Evaluator:
Screen Shot 2024-09-10 at 10 14 11 AM

Screen Shot 2024-09-10 at 10 14 28 AM

stonefilipczak and others added 30 commits July 23, 2024 10:16
@stonefilipczak
government banner
8c1faf3
@stonefilipczak
Merge branch 'dev' into 25_eval_header
65e05eb
@stonefilipczak
header
9e3f4d7
@stonefilipczak
mobile nav
6b758b0
@stonefilipczak
progress
7c1e8be
@stonefilipczak
logged out
589baf3
@stonefilipczak
Merge branch 'dev' into 25_eval_header
f2e0424
@stonefilipczak
sub nav
4e770a9
@stonefilipczak
mobile nav minutae
b618daa
@stonefilipczak @stepchud
Apply suggestions from code review
8e9a0c4 
Co-authored-by: Stephen Chudleigh <[email protected]>
@stonefilipczak
conditional rendering on logged in state
6b50585
@stonefilipczak
user role conditionals
79f8309
@stonefilipczak
add test
28a6fe7
@stonefilipczak
styling minutae
532e88e
@stonefilipczak
remove trailing whitespace
1c8ffda
@stonefilipczak
?
ebd7921
@stonefilipczak @stepchud
Apply suggestions from code review
2f168d3 
Co-authored-by: Stephen Chudleigh <[email protected]>
@stonefilipczak
refactor conditional render
0833135
@stonefilipczak
refactor desktop utility menu links into rails helper/partial
3312eef
@stonefilipczak
shared specs for utility menu
6fc45ac
@stepchud
Merge branch 'dev' into 25_eval_header
9e45fe9
@stepchud
make utility menu more responsive
1bcf5d9 
remove unused partial template
@stonefilipczak
add specs for user roles and install pry
824a4bc
@stonefilipczak
refactor utility menu links for mobile
91b5739
@stonefilipczak
no wrap on utility links
52454b5
@stonefilipczak
create login user method for specs
19f2579
@stepchud
Merge branch 'dev' into 25_eval_header
147fccb
@stonefilipczak
extend header tests to dashboard route
3532264
@stonefilipczak
address what linter believes to be duplicated code blocks
6173cec
@stonefilipczak
remove trailing whitespace
b1301c6
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 09/10/24 milestone Aug 30, 2024
This was linked to issues Aug 30, 2024
Challenge Manager's Dashboard (Rails) #53
Closed
Create shared Dashboard UI components #126
Closed
@stepchud stepchud self-requested a review September 3, 2024 20:39
stepchud
stepchud requested changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple things to add, code looks good 👍
figma link for reference

app/helpers/dashboard_helper.rb Outdated Show resolved Hide resolved
app/helpers/dashboard_helper.rb Outdated Show resolved Hide resolved
app/helpers/dashboard_helper.rb Outdated Show resolved Hide resolved
app/views/dashboard/_dashboard.html.erb Outdated Show resolved Hide resolved
app/helpers/dashboard_helper.rb Outdated Show resolved Hide resolved
@stonefilipczak stonefilipczak changed the title [53, 126] Dashboard Component / Challenge Manager's Dashboard [52, 53, 126] Dashboard Component / Challenge Manager's Dashboard / Evaluator's Dashboard Sep 10, 2024
stepchud
stepchud approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, cleaned up the CSS a bit and added specs for the evaluator's dashboard and a11y (see: 5a87221)

app/helpers/dashboard_helper.rb
def dashboard_cards_by_role
{
challenge_manager: [
{ image_path: 'emoji_events', href: 'http://localhost:4000/', alt: 'challenges', title: 'Challenges',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: update this URL and other hard-coded localhost:4000 when #128 merges

@stepchud stepchud merged commit 583a417 into dev Sep 16, 2024
11 checks passed
@stepchud stepchud deleted the 53_dashboard_component branch September 16, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepchud stepchud stepchud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 09/24/24
Development

Successfully merging this pull request may close these issues.

Create shared Dashboard UI components Challenge Manager's Dashboard (Rails)
3 participants
@stonefilipczak @stepchud @r-bartlett-gsa