[22 | 24] Users can login/logout via Rails app #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can-login-via-rails * 'dev' of github.com:GSA/Challenge_platform: Update DEVCONFIG.md make CircleCI happier add login.gov certs and configuration
cpreisinger
force-pushed
the
22/user-can-login-via-rails
branch
from
bc92afe to
f645e0e
Compare
stepchud
reviewed
Aug 7, 2024
stepchud
reviewed
Aug 7, 2024
There was a problem hiding this comment.
The login/logout functionality seems like it's working but when I run bundle exec rspec locally on your branch, I get a simplecov error:
✗ bundle exec rspec
....................
Finished in 0.29338 seconds (files took 1.4 seconds to load)
20 examples, 0 failures
Coverage report generated for RSpec to /Users/stephen/code/Challenge_platform/coverage. 253 / 276 LOC (91.67%) covered.
/Users/stephen/code/Challenge_platform/.nix-bundler/ruby/3.2.0/gems/simplecov-0.17.1/lib/simplecov.rb:243:in `result_exit_status': undefined method `-' for nil:NilClass (NoMethodError)
coverage_diff = last_run["result"]["covered_percent"] - covered_percent
^
from /Users/stephen/code/Challenge_platform/.nix-bundler/ruby/3.2.0/gems/simplecov-0.17.1/lib/simplecov.rb:224:in `process_result'
from /Users/stephen/code/Challenge_platform/.nix-bundler/ruby/3.2.0/gems/simplecov-0.17.1/lib/simplecov.rb:205:in `run_exit_tasks!'
from /Users/stephen/code/Challenge_platform/.nix-bundler/ruby/3.2.0/gems/simplecov-0.17.1/lib/simplecov/defaults.rb:29:in `block in <top (required)>'
is there a way to fix it?
nevermind, this is happening on dev already. I thought it was related to this PR since you mentioned something about simplecov this morning.
EDIT: I'm not seeing it anymore
stepchud
requested changes
Aug 7, 2024
…can-login-via-rails * 'dev' of github.com:GSA/Challenge_platform: fix User attributes, add shared example spec updated tests for logged_at validation Update app/models/security_log.rb created shared_examples for redundant tests fix typo linting and annotations Created rails security log model and basic spec test
stepchud
approved these changes
Aug 9, 2024
| @@ -64,6 +71,32 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe 'timestamps' do | |||
| it 'properly sets inserted_at and updated_at' do | |||
Comment on lines
+10
to
+14
| def self.timestamp_attributes_for_create | ||
| # only strings allowed here, symbols won't work, see below commit for more details | ||
| # https://github.com/rails/rails/commit/2b5dacb43dd92e98e1fd240a80c2a540ed380257 | ||
| super << 'inserted_at' | ||
| end |
| @@ -66,4 +66,6 @@ | |||
| config.filter_rails_from_backtrace! | |||
| # arbitrary gems may also be filtered via: | |||
| # config.filter_gems_from_backtrace("gem name") | |||
|
|
|||
| config.include ActiveSupport::Testing::TimeHelpers | |||
Closed
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22
#24