Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same as #16, but with correct file permissions. (Not line endings.) #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NoMod-Programming
Copy link
Collaborator

This version is the exact same as #16, but with the correct file permissions (which means that the diffs show correctly now).

@ckissane
Copy link

Cool

@GRA0007
Copy link
Owner

GRA0007 commented Nov 29, 2016

I would love to merge this, but as much as I hate to say it, the UI doesn't look very nice at all. I know you worked hard on it and I'm really sorry, but that shade of blue, along with the blue border, the animations, the font, etc., they simply don't fit with the theme. I like the "backend" changes, such as the variable colours, but unfortunately I simply cannot merge this request. If you want, it'd be great if you submitted a request with just the programmatic changes, and none of the UI changes. I'd definitely merge that. Sorry again that I can't merge this request @coler706.

@ckissane
Copy link

OK I can try to just get the programming part.

@ckissane
Copy link

ckissane commented Dec 5, 2016

I agree that the ui may not currently fit in well but with some more work (which I am willing to do) I think it could turn out quite well. What could I do to make the UI "acceptable"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants