Increase color clarity in the multi-variant viewer #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
example on haploid genome data from https://marchantia.info/ (trying to reproduce this figure from their paper chr8:5,150,022..5,204,022) this branch 
main branch |
|
probably worth making this color scheme configurable and add legends |
cmdcolin
force-pushed
the
more_bold_colors
branch
from
68425f0 to
84e35e2
Compare
cmdcolin
force-pushed
the
more_bold_colors
branch
from
118bbf9 to
c14af32
Compare
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variant matrix tries to 'mix' colors, but in some cases, it will mix colors in a way that washes out the 'uncalled' signal
This PR avoids doing a color mix if there were no e.g. alt alleles at all and it is 100% uncalled.