Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve export functionality #1837

Merged
merged 2 commits into from
Aug 12, 2024
Merged

feat: improve export functionality #1837

merged 2 commits into from
Aug 12, 2024

Conversation

takb
Copy link
Contributor

@takb takb commented Aug 8, 2024

Information about the changes

  • trigger export by env var or runtime property
  • set filename for export from variables
  • refactored ORSInitContextListener and added a test

@takb takb requested a review from MichaelsJP August 8, 2024 06:59
@github-actions github-actions bot added feature and removed feature labels Aug 8, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
73.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@takb takb requested a review from jhaeu August 12, 2024 09:51
@github-actions github-actions bot added feature and removed feature labels Aug 12, 2024
jhaeu
jhaeu approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@jhaeu jhaeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@takb takb merged commit 018a108 into feat/config-wrapup Aug 12, 2024
19 of 41 checks passed
@takb takb deleted the feat/config-wrapup-export branch August 12, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhaeu jhaeu jhaeu approved these changes

@MichaelsJP MichaelsJP Awaiting requested review from MichaelsJP

Assignees
No one assigned
Labels
feature
Projects
No open projects
ors general
Status: Awaiting release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takb @jhaeu