Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve release script for macOS and Linux compatibility #859

Merged
merged 2 commits into from
Dec 10, 2024
Merged

improve release script for macOS and Linux compatibility #859

merged 2 commits into from
Dec 10, 2024

Conversation

joker234
Copy link
Member

Description

  • improved release script
  • make it compatible macOS and Linux

Corresponding issue

None

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
    - [ ] I have commented my code
    - [ ] I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@joker234 joker234 added the CI Related to continuous integration (unit tests, build settings, etc.) label Dec 10, 2024
@joker234 joker234 requested a review from mmerdes December 10, 2024 11:08
@joker234 joker234 force-pushed the release-script-enhancement branch from 4672e10 to 6c996de Compare December 10, 2024 11:14
mmerdes
mmerdes approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@mmerdes mmerdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked it twice in a 'twin' project using MacOS.

@mmerdes mmerdes merged commit 6d82eac into main Dec 10, 2024
2 checks passed
@mmerdes mmerdes deleted the release-script-enhancement branch December 10, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmerdes mmerdes mmerdes approved these changes

Assignees
No one assigned
Labels
CI Related to continuous integration (unit tests, build settings, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joker234 @mmerdes