Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configuration loop acceleration for SolidMechanicsLagrangeContact #3349

Open
wants to merge 87 commits into
base: develop
Choose a base branch
from

Conversation

sohailwaziri
Copy link
Contributor

@sohailwaziri sohailwaziri commented Sep 12, 2024

image
image

@paveltomin paveltomin changed the base branch from develop to swaziri/experimental September 23, 2024 22:32
@paveltomin
Copy link
Contributor

@castelletto1 @matteofrigo5 @CusiniM this is actually ready to have a look

Base automatically changed from swaziri/experimental to develop November 28, 2024 16:37
@rrsettgast
Copy link
Member

@paveltomin @sohailwaziri
From the slide image and a quick glance at the code it is unclear exactly what is happening here. Can you explain in words the what is being done. For example, it seems you are trying to "accelerate" the evolution of the shear stress....is that the correct interpretation? What is the "accelerated variable" in this case? Is it the shear traction?...etc. A detailed discussion would be great. Perhaps at the Thursday meeting?

@paveltomin paveltomin added flag: requires rebaseline Requires rebaseline branch in integratedTests and removed ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 2, 2024
Comment on lines +2362 to +2365
if( configurationLoopIter == 0 )
{
m_x0[kfe] = currentTau_unscaled - limitTau;
}
Copy link
Contributor

@castelletto1 castelletto1 Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the example suggested by @matteofrigo5 (ContactMechanics_SimpleCubes_smoke).

It happens that total_size computed in initializeAccelerationVariables is equal to 0, hence GEOS crashes here because m_x0 has zero size, as all the other allocated arrays needed for the nonlinear acceleration.

I suspect it is because in that example the SurfaceGenerator is used to split the mesh.

@sohailwaziri: please make sure initializeAccelerationVariables is called after the mesh has been split, when the SurfaceGenerator is used. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the example suggested by @matteofrigo5 (ContactMechanics_SimpleCubes_smoke).

It happens that total_size computed in initializeAccelerationVariables is equal to 0, hence GEOS crashes here because m_x0 has zero size, as all the other allocated arrays needed for the nonlinear acceleration.

I suspect it is because in that example the SurfaceGenerator is used to split the mesh.

@sohailwaziri: please make sure initializeAccelerationVariables is called after the mesh has been split, when the SurfaceGenerator is used. Thanks!

i got it fixed by moving initializeAccelerationVariables into setupSystem

without acceleration:

lagrangiancontact, number of time steps: 11
lagrangiancontact, number of successful outer loop iterations: 13
lagrangiancontact, number of successful nonlinear iterations: 94
lagrangiancontact, number of successful linear iterations: 94
lagrangiancontact, number of time step cuts: 1
lagrangiancontact, number of discarded outer loop iterations: 5
lagrangiancontact, number of discarded nonlinear iterations: 35
lagrangiancontact, number of discarded linear iterations: 35

with acceleration:

lagrangiancontact, number of time steps: 11
lagrangiancontact, number of successful outer loop iterations: 13
lagrangiancontact, number of successful nonlinear iterations: 95
lagrangiancontact, number of successful linear iterations: 95
lagrangiancontact, number of time step cuts: 1
lagrangiancontact, number of discarded outer loop iterations: 5
lagrangiancontact, number of discarded nonlinear iterations: 35
lagrangiancontact, number of discarded linear iterations: 35

so acceleration does not hurt but does not help either
maybe some parameter needs to be tuned as Sohail mentioned yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants