Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reviewed] [Fire bullet] Fix bullets picking #877

Merged
merged 1 commit into from
May 23, 2023
Merged

[Reviewed] [Fire bullet] Fix bullets picking #877

merged 1 commit into from
May 23, 2023

Conversation

D8H
Copy link
Contributor

@D8H D8H commented May 14, 2023

  • Actions can now be applied to the bullet created by the extension.

Demo

@D8H
[Fire bullet] Fix bullets picking
5f27a41 
* Actions can now be applied to the bullet created by the extension.
@D8H D8H added 🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. labels May 14, 2023
@D8H D8H requested a review from a team as a code owner May 14, 2023 18:42
@D8H D8H self-assigned this May 14, 2023
@D8H D8H mentioned this pull request May 14, 2023
Open
@D8H D8H added the 🏗 Need a change in GDevelop This extension needs a change in GDevelop to work label May 14, 2023
@4ian
Copy link
Collaborator

4ian commented May 14, 2023

Thank you 🙏

@D8H D8H changed the title [Fire bullet] Fix bullets picking [Reviewed] [Fire bullet] Fix bullets picking May 16, 2023
tristanbob
tristanbob reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@tristanbob tristanbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this game and I was able to make changes to the newly created bullets, similar to the normal "create object" action.

@D8H D8H removed the 🏗 Need a change in GDevelop This extension needs a change in GDevelop to work label May 23, 2023
@D8H D8H merged commit 7a4ec67 into main May 23, 2023
@D8H D8H deleted the fire-bullet-picking branch May 23, 2023 11:29
@tristanbob tristanbob mentioned this pull request Jun 23, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanbob tristanbob tristanbob left review comments

Assignees

@D8H D8H

Labels
🔄 Extension update An update for an existing extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D8H @4ian @tristanbob