-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style/#267: 건물번호 필터링 버튼 위치 변경 && 토스트 메세지 구현 #270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp449
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지도 필터랑 아이콘이 훨씬 잘 보이고 좋아진거 같아요
토스트 메세지도 예쁘고 사용하기 쉽게 만들어뒀군요 👍
지도에 고생이 많네요,,, ㅋㅋㅋ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤠 개요
💫 설명
토스트 추가하기
addToast
함수에 전달할 메세지와, 아이콘을 전달해주면 뷰포트 기준 오른쪽 아래에 2초동안 토스트 메세지가 렌더링 돼요컴포넌트 분리
BuildingFilterButtons
컴포넌트에서 건물번호 오버레이를 렌더링 할건지를 결정하는 버튼을 렌더링 하고, 사용자 위치를 새로고침 하는 아이콘도 렌더링 하고 있었는데,📷 스크린샷 (Optional)
KakaoTalk_Video_2023-10-13-11-12-50.mp4