Feature/#3 노션 API 테스트 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f3aea3.
coke98
reviewed
Sep 17, 2022
| private final String TOKEN = ""; | ||
| private final String DATABASE_ID = ""; | ||
| private final String tableName = "MEMBER PROFILE"; | ||
| private final int memberNum = 3; |
There was a problem hiding this comment.
memberNum은 회원 수를 말하는 거죠?? 테스트 용으로 임의로 3명으로 지정해 놓은 변수로 이해하면 될까요?
| //then | ||
| assertThat(simpleQueryResultPage.results.size()).isEqualTo(1); | ||
| // System.out.println("simpleQueryResultPage = " + simpleQueryResultPage.results.get(0).getPropertyValues()); | ||
| assertThat(simpleQueryResultPage.results.get(0).getPropertyValues().toString().contains(email)).isEqualTo(true); |
There was a problem hiding this comment.
equals 써서 바로 string 비교할 수도 있지 않나요? 호옥시 contains.equals(true)로 한 이유가 있을까요?? 저도 잘 몰라서 질문 드려용
There was a problem hiding this comment.
simpleQueryResultPage.results.get(0).getPropertyValues()
-> 이렇게 하면 사용자 이름, 이메일, 역할에 관한 정보가 들어가 있긴 한데
bold=false, italic=false, strikethrough=false, underline=false 이런 정보들도 같이 나와서 contains 사용했습니다.
simpleQueryResultPage.results.get(0).getPropertyValues().get(0).getValue()
-> 하면 이메일 정보만 따로 나오긴 하는데 여기에도 다른 정보들도 같이 나와서 일단 저렇게 작성해뒀습니다.
- 원하는 email, name, role 값만 꺼내려는데 잘 안돼서 contains 사용했는데 고칠 필요가 있을 것 같습니다!
There was a problem hiding this comment.
실제 사용하는 과정에서는 파싱해서 email, name, role만 따로 가져올 필요가 있겠네요.
답변 감사합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the PR?
Changes
Test Check List
etc