Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 멤버 가입 신청 request dto 수정 #68

Merged
merged 2 commits into from
Feb 12, 2024
Merged

refactor: 멤버 가입 신청 request dto 수정 #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a2e6e
refactor: 멤버 가입 신청 request dto 수정
Sangwook02 Feb 12, 2024
10ff2c4
style: spotless apply
Sangwook02 Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/main/java/com/gdschongik/gdsc/domain/member/application/OnboardingMemberService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ public class OnboardingMemberService {
public void signupMember(MemberSignupRequest request) {
Member currentMember = memberUtil.getCurrentMember();
currentMember.signup(
request.studentId(),
request.name(),
request.phone(),
request.department(),
request.email(),
request.discordUsername(),
request.nickname());
request.studentId(), request.name(), request.phone(), request.department(), request.email());
}
}
11 changes: 1 addition & 10 deletions src/main/java/com/gdschongik/gdsc/domain/member/domain/Member.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,7 @@ public static Member createGuestMember(String oauthId) {
.build();
}

public void signup(
String studentId,
String name,
String phone,
String department,
String email,
String discordUsername,
String nickname) {
public void signup(String studentId, String name, String phone, String department, String email) {
validateStatusUpdatable();
validateUnivStatus();

Expand All @@ -114,8 +107,6 @@ public void signup(
this.phone = phone;
this.department = department;
this.email = email;
this.discordUsername = discordUsername;
this.nickname = nickname;
}

public void withdraw() {
Expand Down
7 changes: 1 addition & 6 deletions src/main/java/com/gdschongik/gdsc/domain/member/dto/request/MemberSignupRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,4 @@ public record MemberSignupRequest(
@Schema(description = "전화번호", pattern = PHONE)
String phone,
@NotBlank @Schema(description = "학과") String department,
@NotBlank @Email @Schema(description = "이메일") String email,
@NotBlank @Schema(description = "discord username") String discordUsername,
@NotBlank
@Pattern(regexp = NICKNAME, message = "닉네임은 " + NICKNAME + " 형식이어야 합니다.")
@Schema(description = "커뮤니티 닉네임", pattern = NICKNAME)
String nickname) {}
@NotBlank @Email @Schema(description = "이메일") String email) {}
Loading