chore: Swagger 세팅 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sangwook02
requested changes
Feb 11, 2024
| @@ -5,6 +5,7 @@ public class SecurityConstant { | |||
| public static final String REGISTRATION_REQUIRED_HEADER = "Registration-Required"; | |||
| public static final String TOKEN_ROLE_NAME = "role"; | |||
| public static final String GITHUB_NAME_ATTR_KEY = "id"; | |||
| public static final String TOKEN_HEADER_PREFIX = "Bearer "; | |||
There was a problem hiding this comment.
토큰 타입으로는 BEARER가 아닌 다른 타입도 올 수 있으니 BEARER_PREFIX와 같은 이름이 의미를 더 잘 담는 것 같습니다.
어떤가요?
There was a problem hiding this comment.
ACCESS_TOKEN_PREFIX 로 변경하도록 하겠습니다~
Bearer같이 내부의 리터럴 값보다는 사용되는 맥락의 의미가 잘 드러난다고 생각해요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
@ConditionalOnProperty사용하여 스웨거 전용 필터체인을 만들었습니다.📝 참고사항
📚 기타