feat: 출결번호가 네 자리 수가 되도록 String 타입으로 수정 (#858)

* feat: 스터디회차의 출석번호를 String으로 변경 * feat: 출석번호 생성기 인터페이스 및 구현체 수정
GDSC-Hongik · Jan 30, 2025 · dd3d474 · dd3d474
1 parent 621c9a2
commit dd3d474
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/main/java/com/gdschongik/gdsc/domain/studyv2/domain/AttendanceNumberGenerator.java b/src/main/java/com/gdschongik/gdsc/domain/studyv2/domain/AttendanceNumberGenerator.java
@@ -1,5 +1,5 @@
 package com.gdschongik.gdsc.domain.studyv2.domain;
 
 public interface AttendanceNumberGenerator {
-    int generate();
+    String generate();
 }
diff --git a/src/main/java/com/gdschongik/gdsc/domain/studyv2/domain/RandomAttendanceNumberGenerator.java b/src/main/java/com/gdschongik/gdsc/domain/studyv2/domain/RandomAttendanceNumberGenerator.java
@@ -13,10 +13,10 @@ public class RandomAttendanceNumberGenerator implements AttendanceNumberGenerato
 
     @Override
     @SneakyThrows
-    public int generate() {
-        return SecureRandom.getInstanceStrong()
+    public String generate() {
+        return String.valueOf(SecureRandom.getInstanceStrong()
                 .ints(MIN_ORIGIN, MAX_BOUND)
                 .findFirst()
-                .orElseThrow();
+                .orElseThrow());
     }
 }
diff --git a/src/main/java/com/gdschongik/gdsc/domain/studyv2/domain/StudySessionV2.java b/src/main/java/com/gdschongik/gdsc/domain/studyv2/domain/StudySessionV2.java
@@ -42,7 +42,7 @@ public class StudySessionV2 extends BaseEntity {
     // 수업 관련 필드
 
     @Comment("수업 출석 번호")
-    private Integer lessonAttendanceNumber;
+    private String lessonAttendanceNumber;
 
     @Embedded
     @AttributeOverride(name = "startDate", column = @Column(name = "lesson_start_at"))
@@ -76,7 +76,7 @@ private StudySessionV2(
             Integer position,
             String title,
             String description,
-            Integer lessonAttendanceNumber,
+            String lessonAttendanceNumber,
             Period lessonPeriod,
             String assignmentDescriptionLink,
             Period assignmentPeriod,
@@ -92,7 +92,7 @@ private StudySessionV2(
         studyV2.getStudySessions().add(this);
     }
 
-    public static void createEmpty(Integer position, Integer lessonAttendanceNumber, StudyV2 studyV2) {
+    public static void createEmpty(Integer position, String lessonAttendanceNumber, StudyV2 studyV2) {
         StudySessionV2.builder()
                 .position(position)
                 .lessonAttendanceNumber(lessonAttendanceNumber)

diff --git a/src/test/java/com/gdschongik/gdsc/domain/studyv2/domain/StudyFactoryTest.java b/src/test/java/com/gdschongik/gdsc/domain/studyv2/domain/StudyFactoryTest.java
@@ -15,8 +15,8 @@ class StudyFactoryTest {
 
     static class FixedAttendanceNumberGenerator implements AttendanceNumberGenerator {
         @Override
-        public int generate() {
-            return 1000;
+        public String generate() {
+            return "0000";
         }
     }
 
@@ -104,6 +104,6 @@ public int generate() {
         // then
         assertThat(study.getStudySessions())
                 .extracting(StudySessionV2::getLessonAttendanceNumber)
-                .containsOnly(1000);
+                .containsOnly("0000");
     }
 }