refactor: 멤버 도메인이 dto에 의존하지 않도록 개선 (#65)

GDSC-Hongik · Feb 12, 2024 · 39ebc9a · 39ebc9a
1 parent 1dbdbef
commit 39ebc9a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 10 deletions.
diff --git a/src/main/java/com/gdschongik/gdsc/domain/member/application/MemberService.java b/src/main/java/com/gdschongik/gdsc/domain/member/application/MemberService.java
@@ -39,7 +39,14 @@ public void withdrawMember(Long memberId) {
     public void updateMember(Long memberId, MemberUpdateRequest request) {
         Member member =
                 memberRepository.findById(memberId).orElseThrow(() -> new CustomException(ErrorCode.MEMBER_NOT_FOUND));
-        member.updateMemberInfo(request);
+        member.updateMemberInfo(
+                request.studentId(),
+                request.name(),
+                request.phone(),
+                request.department(),
+                request.email(),
+                request.discordUsername(),
+                request.nickname());
     }
 
     public Page<MemberPendingFindAllResponse> findAllPendingMembers(Pageable pageable) {

diff --git a/src/main/java/com/gdschongik/gdsc/domain/member/domain/Member.java b/src/main/java/com/gdschongik/gdsc/domain/member/domain/Member.java
@@ -3,7 +3,6 @@
 import static com.gdschongik.gdsc.global.exception.ErrorCode.*;
 
 import com.gdschongik.gdsc.domain.common.model.BaseTimeEntity;
-import com.gdschongik.gdsc.domain.member.dto.request.MemberUpdateRequest;
 import com.gdschongik.gdsc.global.exception.CustomException;
 import jakarta.persistence.Column;
 import jakarta.persistence.Embedded;
@@ -114,16 +113,23 @@ private boolean isForbidden() {
         return this.status.isForbidden();
     }
 
-    public void updateMemberInfo(MemberUpdateRequest request) {
+    public void updateMemberInfo(
+            String studentId,
+            String name,
+            String phone,
+            String department,
+            String email,
+            String discordUsername,
+            String nickname) {
         validateStatusUpdatable();
 
-        this.studentId = request.studentId();
-        this.name = request.name();
-        this.phone = request.phone();
-        this.department = request.department();
-        this.email = request.email();
-        this.discordUsername = request.discordUsername();
-        this.nickname = request.nickname();
+        this.studentId = studentId;
+        this.name = name;
+        this.phone = phone;
+        this.department = department;
+        this.email = email;
+        this.discordUsername = discordUsername;
+        this.nickname = nickname;
     }
 
     private void validateStatusUpdatable() {