Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live update disable #50

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

suprjinx
Copy link
Contributor

Fixes #997

@suprjinx suprjinx changed the base branch from main to release/v3.17.5 March 19, 2024 18:13
);
): React.FunctionComponentElement<React.ReactNode> | null {
//@ts-ignore
if (window.live_updates_enabled == 1) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just have to use bool as is without transforming it to int. JSON object safely supports boolean type so we can use it as is.

Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use bool instead of int.

@suprjinx suprjinx merged commit e81fe5a into G-Research:release/v3.17.5 Mar 20, 2024
3 checks passed
@suprjinx suprjinx deleted the live-update-disable branch March 20, 2024 14:42
vinayan3 pushed a commit to vinayan3/fasttrackml-ui-aim that referenced this pull request Aug 28, 2024
* Pickup "live_updates_enabled" field and show/hide accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants