Experiment Selection Header Searchbox + Quick Action Buttons #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiovincenzi
previously approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Looks really good!
I report just few things I noticed but I think we can definitely merge this in and fix these in a separate PR
- when the toggle button is pressed (to set regex search), maybe we want to update the results as well
- if we have an invalid regex input and then we switch to normal search the red box still shows up until you come back to regex search and supply a valid regex.
But as I said really good work, we can fix those in a separate PR.
suprjinx
reviewed
Mar 14, 2024
src/src/pages/Experiment/components/ExperimentSelectionPopover/ExperimentSelectionPopover.tsx
Outdated
Show resolved
Hide resolved
fabiovincenzi
approved these changes
Mar 15, 2024
vinayan3
pushed a commit
to vinayan3/fasttrackml-ui-aim
that referenced
this pull request
Aug 28, 2024
…rch#48) * Add ExperimentNavigationPopoverCompact * Add conditional rendering for compact header/popover * Add ExperimentHeader to MetricsBar * Fix ExperimentHeader styling * Add metrics filtering * Add filtering handler * Add params filter by experiment * Add scatters filtering by experiment * Fix date alignment * Abridge long experiment names * Refactor onSelectExperiment handler * Extend query string parser for experimentNames * Refactor createAppModel internals * Refactor experiment id to experimentNames * Add ExperimentBar component * Add ExperimentSelectionPopover component * Add chips for multiple experiment names * Add styling for experiment bar chips * Remove compact experiment header * Add default experiment bar text * Remove unused props * Fix shortening issue * Show no results when empty selectedExperiments * Add util for getting selected experiments * Update selectedExperiments toggle function * Refactor component tree to simplify global state * Add onToggleAllExperiments to model * Fix missing dependency warning * Add toggle function to view * Add regex filtering to experiment header * Update onToggleAllExperiments * Add experiment selection checkboxes and new toggle logic * Update experiment selection styling * Improve experiment name slicing UX * Add conditional tooltip to main checkbox * Fix import spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for enhancing the experiment selection header usability by allowing quick selection or removal of filtered experiments, and also filtering/searching experiments by name or by regex expression.
Changelog