Table Column Filtering and Performance Improvements #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i notice that this new control doesn't really change anything in the current table -- should it cause a refresh to "see what's different" (as the others do, such as Manage Columns)? If this only affects the next search, maybe the control should be near the search button? |
suprjinx
approved these changes
May 3, 2024
vinayan3
pushed a commit
to vinayan3/fasttrackml-ui-aim
that referenced
this pull request
Aug 28, 2024
* Add visibility change handler * Add type definitions for column filters * Add internal column filtering logic * Add HideColumnsPopover * Improve table scrolling speeds * Plug new props into each app container * Fix HideColumnsPopover re-rendering problems * Fix Params and Scatters unselected metric filtering --------- Co-authored-by: fabiovincenzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
HideColumnsPopoverfor theTablecomponent which allows switching the default hidden columns when making a query or loading data:Performance improvements:
Scrolling speeds for the Table were optimized by a factor of 3-4, although animation cancelling requires a small loading delay in itself to be effective (~30 ms). Nevertheless, it is a big improvement when in "Hide All" mode, which used to be very laggy by default in spite of having few columns.
Horizontal scrolling is still rather slow, owing to the fact that cells and column values/styles are repeatedly rendered on the fly. This may require more investigation testing to speed things up.