Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove white shadow in metrics charts #42

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

fabiovincenzi
Copy link
Collaborator

Fixes #G-Research/fasttrackml#861.
Remove the white shadow around the active runs metrics as it significantly slowed down performance.

@jescalada
Copy link
Collaborator

There's a great improvement in performance when removing the drop-shadow! It causes a lot of lag because it creates a shadow by diffusing the "shape" of the div which is computationally expensive.

I also noticed a slight increase in performance using the built-in ease-in-out transition, rather than the cubic-bezier, but it might just be my imagination. May I ask how you managed to get 10000 active runs? I can only get so many runs locally until I running out of memory.

@fabiovincenzi
Copy link
Collaborator Author

There's a great improvement in performance when removing the drop-shadow! It causes a lot of lag because it creates a shadow by diffusing the "shape" of the div which is computationally expensive.

I also noticed a slight increase in performance using the built-in ease-in-out transition, rather than the cubic-bezier, but it might just be my imagination. May I ask how you managed to get 10000 active runs? I can only get so many runs locally until I running out of memory.

@jescalada They are actually 5000 active runs with 2 metrics per each

@fabiovincenzi fabiovincenzi merged commit c6a6b35 into G-Research:release/v3.17.5 Feb 16, 2024
3 checks passed
vinayan3 pushed a commit to vinayan3/fasttrackml-ui-aim that referenced this pull request Aug 28, 2024
Remove the white shadow around the active runs metrics as it significantly slowed down performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faster Aim UI: Disable the flashing of active runs in the metric charts
4 participants