Toggle all params and all metrics on ManageColumnsPopover #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jescalada
changed the title
suprjinx
reviewed
Jul 17, 2024
src/src/pages/Metrics/components/Table/HideColumnsPopover/HideColumnsPopover.tsx
Show resolved
Hide resolved
vinayan3
pushed a commit
to vinayan3/fasttrackml-ui-aim
that referenced
this pull request
Aug 28, 2024
…#105) * Add new enums for HideColumns * Add buttons for toggles * Fix broken Hide All button * Implement hide metrics logic * Add alignmentconfig fix * Add conditional virtual rendering for column list * Add frontend triggers * Add show metrics logic * Add hide params logic * Add show params logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for G-Research/fasttrackml#76.
Note that there was an issue with the Hide All button which wasn't working correctly with lots (5000+) of metrics, and also there were some pretty terrible performance issue when pressing any of the triggers.
This PR aims to fix the Hide All logic, as well as patching some of the performance issues (reduces wait times from around 60 seconds down to 2-3 seconds when pressing any trigger, at the cost of not being able to view/search columns correctly when there are 100+ columns). Users are expected to use the Toggle buttons or automatically hiding unselected metrics/params to begin with.
Changelog