Add range selection for runs (shift+click) #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fasttrackml-ui-aim into v3.17.5-ShiftClickRangeSelect
vinayan3
pushed a commit
to vinayan3/fasttrackml-ui-aim
that referenced
this pull request
Aug 28, 2024
* Fix playwright pipeline * Upgrade playwright to 1.45.0 * Add with-deps * Add playwright envs * Change installation order * Do everything in src directory * Set working-directory * Add range start state to Table * Extend onRowSelect to allow range selection * Plug together rangeStart state and callback * Intercept and handle shift click event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for adding Shift+Click range selection functionality for the Runs table (G-Research/fasttrackml#325)
Unfortunately, due to the structure of the data in Runs being different from the Metrics/Params/Scatters tables (because the latter has grouped data), implementing range selection is more complex and less efficient. If required, we can implement those separately, although the original issue asks only to implement this in Runs.
Changelog