Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mismatched types in ABI cast. #6489

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Sep 2, 2024

Description

ABI cast generates TypeInfo::ContractCaller which contains an address that is an expression. While doing the first and second code block passes we would obtain different expressions because of first passes optimizations.

This PR disables first pass optimizations while type checking address expression so there aren't any mismatched types.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal added bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Sep 2, 2024
@esdrubal esdrubal self-assigned this Sep 2, 2024
ABI cast generates TypeInfo::ContractCaller which contains an address
that is an expression. While doing the first and second code block
passes we would obtain different expressions because of first passes
optimizations.

This PR disables first pass optimizations while type checking address
expression so there isn't any mismatched types.
@esdrubal esdrubal force-pushed the esdrubal/fix_code_block_first_pass_abi branch from da7c771 to a889078 Compare September 2, 2024 13:27
Copy link

codspeed-hq bot commented Sep 2, 2024

CodSpeed Performance Report

Merging #6489 will not alter performance

Comparing esdrubal/fix_code_block_first_pass_abi (40639a8) with master (2538442)

Summary

✅ 21 untouched benchmarks

@esdrubal esdrubal marked this pull request as ready for review September 3, 2024 10:02
@esdrubal esdrubal requested a review from a team as a code owner September 3, 2024 10:02
@IGI-111 IGI-111 requested a review from a team September 4, 2024 10:56
@esdrubal esdrubal merged commit 9132ca8 into master Sep 6, 2024
40 checks passed
@esdrubal esdrubal deleted the esdrubal/fix_code_block_first_pass_abi branch September 6, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants