-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduces memory footprint of collecting unifications. #6479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added
performance
Everything related to performance, speed wise or memory wise.
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
labels
Aug 28, 2024
Benchmark for 0908ac4Click to view benchmark
|
tritao
approved these changes
Aug 28, 2024
Benchmark for 4a622d4Click to view benchmark
|
sdankel
approved these changes
Aug 28, 2024
Benchmark for 714cb24Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
performance
Everything related to performance, speed wise or memory wise.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As shown in https://fuellabs.github.io/sway-performance-dashboard/ #6461 introduced a bigger memory footprint.
Lexical scope has a shared OrdMap called
symbols_unique_while_collecting_unifications
that was never cleared.With this commit, it is cleared on each code block along with the clear of collected unifications.
Checklist
Breaking*
orNew Feature
labels where relevant.