Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add overflow and unsafe math tests #6469

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

SwayStar123
Copy link
Collaborator

Description

Adds some in language tests for overflow and unsafe math operations. Ensuring the operations revert

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 self-assigned this Aug 27, 2024
@SwayStar123 SwayStar123 added the testing General testing label Aug 27, 2024
@SwayStar123 SwayStar123 marked this pull request as ready for review August 27, 2024 08:01
@SwayStar123 SwayStar123 requested a review from a team as a code owner August 27, 2024 08:01
@xunilrj xunilrj enabled auto-merge (squash) August 29, 2024 05:49
@xunilrj xunilrj force-pushed the swaystar123/add-unsafe-math-tests branch from 68e2ef8 to 08fc752 Compare August 29, 2024 05:49
@xunilrj xunilrj merged commit 8e20f97 into master Aug 29, 2024
38 of 74 checks passed
@xunilrj xunilrj deleted the swaystar123/add-unsafe-math-tests branch August 29, 2024 06:04
Copy link

Benchmark for a7da720

Click to view benchmark
Test Base PR %
code_action 4.9±0.01ms 5.0±0.08ms +2.04%
code_lens 343.6±7.97ns 341.9±37.45ns -0.49%
compile 1952.5±75.07ms 1923.5±64.65ms -1.49%
completion 4.4±0.06ms 4.4±0.09ms 0.00%
did_change_with_caching 1890.1±15.90ms 1867.1±27.01ms -1.22%
document_symbol 938.1±39.30µs 849.9±19.03µs -9.40%
format 83.5±0.98ms 82.6±1.29ms -1.08%
goto_definition 337.7±6.30µs 336.9±8.26µs -0.24%
highlight 8.7±0.03ms 8.7±0.21ms 0.00%
hover 352.2±5.38µs 345.9±3.64µs -1.79%
idents_at_position 117.2±0.37µs 117.6±0.54µs +0.34%
inlay_hints 656.3±20.32µs 661.9±22.63µs +0.85%
on_enter 2.0±0.13µs 2.0±0.06µs 0.00%
parent_decl_at_position 3.6±0.05ms 3.6±0.04ms 0.00%
prepare_rename 335.5±8.58µs 336.8±11.69µs +0.39%
rename 9.0±0.19ms 9.0±0.07ms 0.00%
semantic_tokens 1219.1±6.53µs 1235.6±14.93µs +1.35%
token_at_position 330.8±2.01µs 331.7±1.17µs +0.27%
tokens_at_position 3.6±0.03ms 3.6±0.04ms 0.00%
tokens_for_file 397.2±1.60µs 396.8±3.04µs -0.10%
traverse 34.0±0.58ms 34.6±1.15ms +1.76%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing General testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants