ASM blocks handling: inlining, DCE, ASM returns without return register #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironcev
added
compiler
Benchmark for 3a8cc80Click to view benchmark
|
vaivaswatha
approved these changes
Aug 8, 2024
IGI-111
approved these changes
Aug 8, 2024
Benchmark for dd8f829Click to view benchmark
|
esdrubal
pushed a commit
that referenced
this pull request
Aug 13, 2024
…er (#6404) ## Description This PR fixes #6332 and #6354 by: - including number of instructions in ASM blocks when calculating overall number of instructions for function inlining. - properly lowering ASM blocks that return unit, `()`, without return register to returning `$zero` in the ASM. Additionally, the PR: - removes dead ASM blocks (that do not have side-effects) in the DCE pass. - prints ASM blocks that return `()` without a register as `-> ()` to make it consistent with functions. - emits a warning if an ASM block is empty. - adds expressive diagnostic for `UninitializedAsmRegShadowsItem` warning and extends the warning for constants and configurables. - removes obsolete `NamespaceAttributeDeprecated` warning and its empty tests. - harmonizes and defines guidelines for ASM instruction comments. Closes #6332. Closes #6354. ## Bytecode size changes Changes in the `fn-inline` and `dce` optimizations had a minimal impact on the bytcode sizes of the `should_pass` test programs. Out of 455 tests, only 13 tests changed sizes. 8 tests got a size increase of 0.8% in average, while 5 tests got size decrease of 3.0% in average. The real-world [compolabs-orderbook](https://github.com/compolabs/orderbook-contract) contract got a minimal size decrease of 0.16%. <details> <summary>Click here for the numbers</summary> Test | Before | After | Decrease | Percentage -- | -- | -- | -- | -- empty_fields_in_storage_struct | 28384 | 28456 | -72 | -0.25 language/deprecated_attribute | 224 | 208 | 16 | 7.14 language/duplicated_storage_keys | 224 | 208 | 16 | 7.14 language/references/dereferencing_operator_dot_on_structs | 124920 | 125272 | -352 | -0.28 language/references/dereferencing_operator_dot_on_tuples | 124920 | 125272 | -352 | -0.28 language/references/dereferencing_operator_index | 92376 | 92344 | 32 | 0.03 language/references/dereferencing_operator_star | 151152 | 151536 | -384 | -0.25 language/references/impl_reference_types | 7840 | 7776 | 64 | 0.81 language/references/reassigning_via_references_passed_and_returned_to_and_from_functions | 39008 | 39184 | -176 | -0.45 language/references/reassigning_via_references_to_expressions | 36920 | 37064 | -144 | -0.39 language/references/reassigning_via_references_to_values | 13952 | 13936 | 16 | 0.11 stdlib/storage_vec_insert | 8480 | 8552 | -72 | -0.85 stdlib/vec_byte_remove | 1904 | 1976 | -72 | -3.78 </details> ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6332 and #6354 by:
(), without return register to returning$zeroin the ASM.Additionally, the PR:
()without a register as-> ()to make it consistent with functions.UninitializedAsmRegShadowsItemwarning and extends the warning for constants and configurables.NamespaceAttributeDeprecatedwarning and its empty tests.Closes #6332.
Closes #6354.
Bytecode size changes
Changes in the
fn-inlineanddceoptimizations had a minimal impact on the bytcode sizes of theshould_passtest programs. Out of 455 tests, only 13 tests changed sizes. 8 tests got a size increase of 0.8% in average, while 5 tests got size decrease of 3.0% in average.The real-world compolabs-orderbook contract got a minimal size decrease of 0.16%.
Click here for the numbers
Checklist
Breaking*orNew Featurelabels where relevant.