Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Removing tags in readme until fix #50

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

calldelegation
Copy link
Contributor

Type of change

  • Documentation

Changes

The following changes have been made:

Removing tags in the readme until fix

Notes

Issue reported in the forum post here

Related Issues

Closes #49

@calldelegation calldelegation requested a review from a team as a code owner December 25, 2023 18:22
Copy link
Contributor

@Braqzen Braqzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike this because they will keep pulling changes from master. The tags are there for a reason. They can pull master themselves and ignore the tags here until the fix is up

@calldelegation calldelegation self-assigned this Dec 26, 2023
Copy link
Member

@bitzoic bitzoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggests we want users to use the master branch which we are strictly discouraging. Users should use the most recent stable releases.

I have made a new release with the src20 keyword: https://github.com/FuelLabs/sway-standards/releases/tag/v0.3.0

@calldelegation
Copy link
Contributor Author

Thanks for the release fix changed it to v0.3.0 instead :)

@calldelegation calldelegation merged commit 7492dd3 into master Dec 27, 2023
1 check passed
@calldelegation calldelegation deleted the docs/failed-tags branch December 27, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Specifying tagged version does not work in forc.toml
3 participants