Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.23.0 #280

Merged
merged 18 commits into from
Aug 1, 2024
Merged

Release v0.23.0 #280

merged 18 commits into from
Aug 1, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Aug 1, 2024

[v0.23.0]

Added

  • #259 Adds a new upgradability library, including associated tests and documentation.
  • #265 Adds the SetMetadataEvent and emits SetMetadataEvent when the _set_metadata() function is called.
  • #270 Adds OrdEq functionality to Signed Integers.
  • #272 Adds the TryFrom implementation from signed integers to unsigned integers.

Changed

  • #265 Enables the metadata events now that the Rust SDK supports wrapped heap types.
  • #269 Hashes the string "admin" and with the bits of an Identity when creating a storage slot to storage an admin in the Admin Library.
  • #276 Prepares for v0.23.0 release.
  • #278 Deprecates the Fixed Point number library.

Fixed

  • #258 Fixes incorrect instructions on how to run tests in README and docs hub.
  • #262 Fixes incorrect ordering comparison for IFP64, IFP128 and IFP256.
  • #263 Fixes I256's returned bits.
  • #263 Fixes I128 and I256's zero or "indent" value.
  • #268 Fixes subtraction involving negative numbers for I8, I16, I32, I64, I128, and I256.
  • #272 Fixes From implementations for Signed Integers with TryFrom.
  • #273 Fixes negative from implementations for Signed Integers.
  • #274 Fixes the swap_configurables() function to correctly handle the case where the bytecode is too large to fit in the buffer.
  • #275 Fixes an infinite loop in the Bytecode root library's _compute_bytecode_root() function.

Breaking

  • #263 Removes the TwosComplement trait in favor of WrappingNeg.

The following demonstrates the breaking change. While this example code uses the I8 type, the same logic may be applied to the I16, I32, I64, I128, and I256 types.

Before:

let my_i8 = i8::zero();
let twos_complement = my_i8.twos_complement();

After:

let my_i8 = i8::zero();
let wrapping_neg = my_i8.wrapping_neg();
  • #272 The From implementation for all signed integers to their respective unsigned integer has been removed. The TryFrom implementation has been added in its place.

Before:

let my_i8: I8 = I8::from(1u8);

After:

let my_i8: I8 = I8::try_from(1u8).unwrap();
  • #273 The neg_from implementation for all signed integers has been removed. The neg_try_from() implementation has been added in its place.

The following demonstrates the breaking change. While this example code uses the I8 type, the same logic may be applied to the I16, I32, I64, I128, and I256 types.

Before:

let my_negative_i8: I8 = I8::neg_from(1u8);

After:

let my_negative_i8: I8 = I8::neg_try_from(1u8).unwrap();
  • #278 Deprecates the Fixed Point number library. The Fixed Point number library is no longer available.

bitzoic and others added 18 commits June 7, 2024 14:20
@bitzoic
Build with Forc.lock file (#254)
3b6959b 
## Type of change

<!--Delete points that do not apply-->

- New feature

## Changes

The following changes have been made:

- Forces CI to build with Forc.lock file

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
@bitzoic @K1-R1
Use docs hub in favor of book (#255)
bdd8de8 
## Type of change

<!--Delete points that do not apply-->

- Improvement (refactoring, restructuring repository, cleaning tech
debt, ...)
- Documentation

## Changes

The following changes have been made:

- Removes the Sway-Libs book deployment from CI
- All instances mentioning the Sway-Libs book now refer to the docs hub
- Removes the Libraries Overview `libraries.md` page in the book in
favor of a more extensive `index.md` home page.
- Updates all links for Sway-Standards to use the docs hub over the
repository

## Notes

- Now that the sway-lib docs hub exists, we no longer need to book.

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: K1-R1 <[email protected]>
@bitzoic
Add empty CHANGELOG.md (#257)
0f47d33 
## Type of change

<!--Delete points that do not apply-->

- New feature

## Changes

The following changes have been made:

- Adds CHANGELOG.md file
- Adds check in PR template to ensure CHANGELOG.md file has been updated

Closes #247 

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
@bitzoic @K1-R1
Update codeowners for swayex team (#256)
b1c57e3 
## Type of change

<!--Delete points that do not apply-->

- Improvement (refactoring, restructuring repository, cleaning tech
debt, ...)

## Changes

The following changes have been made:

- Sway Applications team has been renamed to SwayEx

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

Co-authored-by: K1-R1 <[email protected]>
@bitzoic
Update instructions on how to run tests (#258)
d299d2d 
## Type of change

<!--Delete points that do not apply-->

- Improvement (refactoring, restructuring repository, cleaning tech
debt, ...)

## Changes

The following changes have been made:

- Updates the README with new instructions on how to run tests
- Updates the doc hub with new instructions on how to run tests

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@K1-R1
Upgradability library (#259)
2a869c5 
## Type of change

<!--Delete points that do not apply-->

- New feature
- Documentation

## Changes

The following changes have been made:

- Added a new upgradability library
- Added test for the new lib
- Added docs for the new lib

## Notes

- The upgradability library provides methods to implement the required
and optional functionality from
[SRC-14](https://docs.fuel.network/docs/sway-standards/src-14-simple-upgradeable-proxies/)
as well as additional functionality for ownership of the proxy contract.
Whilst SRC-14 standardizes the target storage slot:
```sway
/// The standard storage slot to store proxy target address.
///
/// Value is `sha256("storage_SRC14_0")`.
pub const SRC14_TARGET_STORAGE: b256 = 0x7bb458adc1d118713319a5baa00a2d049dd64d2916477d2688d76970c898cd55;
```
It doesn't standardize a storage slot for proxy owner. Consequently the
functions that read and write to the storage slot for proxy owner
require a storage key parameter:
```sway
#[storage(read)]
pub fn proxy_owner(proxy_owner_storage_key: StorageKey<State>) -> State {
    proxy_owner_storage_key.read()
}
```
- The upgradability depends on the master branch of sway-standards; as
the current release does not have the up-to-date SRC-14 ABIs. TODOs are
included, and once this PR is merged, an issue to resolve this will be
made.

## Related Issues

<!--Delete everything after the "#" symbol and replace it with a number.
No spaces between hash and number-->

Closes #260 

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@SwayStar123
Fix ordering functions for IFP (#262)
8d97fb3 
## Type of change

- Bug fix

## Changes

The IFP gt and lt functions were incorrectly implemented, this pr fixes
the implementation and adds tests to ensure functionality

## Notes

- Bug was discovered here
https://bugs.immunefi.com/dashboard/submission/32276

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@bitzoic
Adds the SetMetadataEvent (#265)
76cf2cc 
## Type of change

<!--Delete points that do not apply-->

- New feature

## Changes

The following changes have been made:

- Adds a `SetMetadataEvent` struct
- Emits `SetMetadataEvent` when `_set_metadata()` is called
- Enables the metadata tests now that the SDK supports wrapped heap
types.

## Notes

- This was requested by an external member.

## Related Issues

<!--Delete everything after the "#" symbol and replace it with a number.
No spaces between hash and number-->

Closes #264 

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@bitzoic @K1-R1
Signed Integers TwosComplement fix to WrappingNeg (#263)
624b664 
## Type of change

<!--Delete points that do not apply-->

- Bug fix

## Changes

The following changes have been made:

- The `TwosComplement` trait was not correctly implemented. To stay in
line with Rust's practices, the `WrappingNeg` trait now replaces it with
the original desired functionality of the `TwosComplement` trait.
- Bits for `I128` and `I256` are now correct
- The indent for `I128` and `I256` are now correct

## Notes

- This PR changes the folder names in the tests from
`iX_twos_complement_test` to `iX_wrapping_neg_test`.

## Breaking Changes

The following demonstrates the breaking change. While this example code
uses the `I8` type, the same logic may be applied to the `I16`, `I32`,
`I64`, `I128`, and `I256` types.

Before:
```sway
let my_i8 = i8::zero();
let twos_complement = my_i8.twos_complement();
```

After:
```sway
let my_i8 = i8::zero();
let wrapping_neg = my_i8.wrapping_neg();
```

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.

---------

Co-authored-by: K1-R1 <[email protected]>
@bitzoic @SwayStar123
Hash StorageKey slot for Admin library (#269)
5187679 
## Type of change

<!--Delete points that do not apply-->

- Improvement (refactoring, restructuring repository, cleaning tech
debt, ...)

## Changes

The following changes have been made:

- Adds the string "admin" and hashes with the bits of an Identity when
creating the storage slot to storage an admin.

## Notes

- Reported in the Fuel Attackathon

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.

---------

Co-authored-by: SwayStar123 <[email protected]>
@bitzoic
Add OrdEq impl to Signed Integers (#270)
db11dc2 
## Type of change

<!--Delete points that do not apply-->

- New feature

## Changes

The following changes have been made:

- `I8`, `I16`, `I32`, `I64`, `I128`, and `I256` now support `OrdEq`.

Closes #\<issue number\>

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@bitzoic
Fix Signed Integers Subtraction (#268)
c34c84b 
## Type of change

<!--Delete points that do not apply-->

- Bug fix

## Changes

The following changes have been made:

The following changes have been made:

- Fixed when subtracting a negative from a positive number for `I8`,
`I16`, `I32`, `I64`, `I128`, and `I256`.
- Fixed when subtracting two negative numbers for `I8`, `I16`, `I32`,
`I64`, `I128`, and `I256`.

## Notes

- Reported in the Fuel Attackathon

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@bitzoic
Fix From implementation for Signed Integers (#272)
7fdf8ec 
## Type of change

<!--Delete points that do not apply-->

- Bug fix
- New feature
- Improvement (refactoring, restructuring repository, cleaning tech
debt, ...)

## Breaking

The `From` implementation for all signed integers to their respective
unsigned integer has been removed. The `TryFrom` implementation has been
added in its place.

The following demonstrates the breaking change. While this example code
uses the I8 type, the same logic may be applied to the I16, I32, I64,
I128, and I256 types.

Before:
```sway
let my_i8: I8 = I8::from(1u8);
```

After:
```sway
let my_i8: I8 = I8::try_from(1u8).unwrap();
```

## Changes

The following changes have been made:

- Removes the `From` implementation for `u8` into `I8`
- Removes the `From` implementation for `u16` into `I16`
- Removes the `From` implementation for `u32` into `I32`
- Removes the `From` implementation for `u64` into `I64`
- Removes the `From` implementation for `U128` into `I128`
- Removes the `From` implementation for `u256` into `I256`
- Adds the `TryFrom` implementation for `u8` into `I8`
- Adds the `TryFrom` implementation for `u16` into `I16`
- Adds the `TryFrom` implementation for `u32` into `I32`
- Adds the `TryFrom` implementation for `u64` into `I64`
- Adds the `TryFrom` implementation for `U128` into `I128`
- Adds the `TryFrom` implementation for `u256` into `I256`
- Adds the `TryFrom` implementation for `I8` into `u8`
- Adds the `TryFrom` implementation for `I16` into `u16`
- Adds the `TryFrom` implementation for `I32` into `u32`
- Adds the `TryFrom` implementation for `I64` into `u64`
- Adds the `TryFrom` implementation for `I128` into `U128`
- Adds the `TryFrom` implementation for `I256` into `u256`

## Notes

- Reported in the Fuel Attackathon
- This is a breaking change
- Previously the `From` implementations would revert if the input was
greater than the indent.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@bitzoic
Fix neg_from() in favor of neg_try_from() for Signed Integers (#273)
ddfe684 
## Type of change

<!--Delete points that do not apply-->

- Bug fix

## Breaking

The `neg_from` implementation for all signed integers has been removed.
The `neg_try_from()` implementation has been added in its place.

The following demonstrates the breaking change. While this example code
uses the I8 type, the same logic may be applied to the I16, I32, I64,
I128, and I256 types.

Before:
```sway
let my_negative_i8: I8 = I8::neg_from(1u8);
```

After:
```sway
let my_negative_i8: I8 = I8::neg_try_from(1u8).unwrap();
```

## Changes

The following changes have been made:

- Removes `neg_from()` in favor of `neg_try_from()` for `I8`
- Removes `neg_from()` in favor of `neg_try_from()` for `I16`
- Removes `neg_from()` in favor of `neg_try_from()` for `I32`
- Removes `neg_from()` in favor of `neg_try_from()` for `I64`
- Removes `neg_from()` in favor of `neg_try_from()` for `I128`
- Removes `neg_from()` in favor of `neg_try_from()` for `I256`

## Notes

- This is a breaking change
- Previously the `neg_from()` implementation would break on values
greater than the indent for each signed integer

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@K1-R1
Deprecate Fixed Point library (#278)
0b64cbf
@SwayStar123 @bitzoic
Fix buffer overflow in swap_configurables (#274)
3a8a5dc 
## Type of change

- Bug fix

## Changes

The following changes have been made:

- Changes the swap_configurables function to assert that the offset and
length of the configurable bytes are less than the bytecode length, in
order to avoid a buffer overflow

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.

---------

Co-authored-by: Cameron Carstens <[email protected]>
@bitzoic
Handle case when bytecode is empty (#275)
dbd5e36 
## Type of change

<!--Delete points that do not apply-->

- Bug fix

## Changes

The following changes have been made:

- `_compute_bytecode_root()` now reverts when the `bytecode` argument is
an empty slice. Previously the function would enter an infinite loop.

## Notes

- This was reported as part of the attackathon

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@bitzoic
Prepare for v0.23.0 release (#276)
e205b05 
## Type of change

<!--Delete points that do not apply-->

- Release

## Changes

The following changes have been made:

- Updates all instances of `v0.22.0` to `v0.23.0`

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
- [x] I have updated the changelog to reflect the changes on this PR.
@bitzoic bitzoic added the Repo Misc General repository upkeep label Aug 1, 2024
@bitzoic bitzoic requested a review from a team August 1, 2024 13:05
@bitzoic bitzoic self-assigned this Aug 1, 2024
@K1-R1 K1-R1 requested a review from a team August 1, 2024 13:08
@K1-R1 K1-R1 merged commit 9987d8a into release Aug 1, 2024
17 checks passed
@K1-R1 K1-R1 deleted the release-v0.23.0 branch August 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1-R1 K1-R1 K1-R1 approved these changes

@SwayStar123 SwayStar123 SwayStar123 approved these changes

Assignees

@bitzoic bitzoic

Labels
Repo Misc General repository upkeep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitzoic @SwayStar123 @K1-R1