Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect binary link target #665

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix incorrect binary link target #665

merged 1 commit into from
Oct 28, 2024

Conversation

alfiedotwtf
Copy link
Contributor

When a proxy CLI'd command downloads a missing toolchain, multiple binary files within the downloaded distribution were being symlinked to the same one target file (thus overwriting each previous target).

This fixes an issue found while investigating #654.

@alfiedotwtf alfiedotwtf added bug Something isn't working fuelup labels Oct 4, 2024
@alfiedotwtf alfiedotwtf requested a review from a team October 4, 2024 06:36
@alfiedotwtf alfiedotwtf self-assigned this Oct 4, 2024
@fuel-service-user
Copy link
Contributor

fuel-service-user commented Oct 4, 2024 •
edited
Loading

LCOV of commit 6e55380 during CI #2079

Summary coverage rate:
  lines......: 85.9% (2453 of 2854 lines)
  functions..: 45.8% (378 of 825 functions)
  branches...: 63.1% (289 of 458 branches)

Files changed coverage rate: n/a

@alfiedotwtf alfiedotwtf mentioned this pull request Oct 4, 2024
Merged
@alfiedotwtf alfiedotwtf force-pushed the alfie/fix-binary-link branch 2 times, most recently from d3cfecc to a3cccdf Compare October 4, 2024 09:57
@alfiedotwtf alfiedotwtf mentioned this pull request Oct 4, 2024
Open
@alfiedotwtf alfiedotwtf marked this pull request as draft October 22, 2024 00:07
@alfiedotwtf alfiedotwtf mentioned this pull request Oct 24, 2024
Merged
@alfiedotwtf alfiedotwtf changed the title Fix incorrect binary link target (#654) Fix incorrect binary link target Oct 27, 2024
@alfiedotwtf alfiedotwtf force-pushed the alfie/fix-binary-link branch from a3cccdf to 570c4da Compare October 27, 2024 15:56
@alfiedotwtf alfiedotwtf marked this pull request as ready for review October 27, 2024 15:56
@alfiedotwtf alfiedotwtf requested a review from a team October 27, 2024 15:57
@alfiedotwtf
Fix incorrect binary link target (#654)
6e55380 
When a proxy CLI'd command downloads a missing toolchain, multiple binary files within the downloaded distribution were being symlinked to the same one target file (thus overwriting each previous target).
@alfiedotwtf alfiedotwtf force-pushed the alfie/fix-binary-link branch from 570c4da to 6e55380 Compare October 28, 2024 00:13
@alfiedotwtf alfiedotwtf merged commit 3a60dec into master Oct 28, 2024
17 checks passed
@alfiedotwtf alfiedotwtf deleted the alfie/fix-binary-link branch October 28, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@sdankel sdankel Awaiting requested review from sdankel

Assignees

@alfiedotwtf alfiedotwtf

Labels
bug Something isn't working fuelup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alfiedotwtf @fuel-service-user @JoshuaBatty @sdankel