-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make the latest channel point to beta-4 #506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
force-pushed
the
kayagokalp/latest-beta-4
branch
from
November 8, 2023 02:28
fd8a1a8
to
e3233f7
Compare
Voxelot
reviewed
Nov 8, 2023
Voxelot
previously approved these changes
Nov 8, 2023
sdankel
reviewed
Nov 8, 2023
sdankel
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update docs as well?
sdankel
previously approved these changes
Nov 8, 2023
JoshuaBatty
requested changes
Nov 8, 2023
Co-authored-by: Joshua Batty <[email protected]>
JoshuaBatty
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes latest channel to point beta-4 which is the latest network. We can later on create a new channel with a different name (maybe
latest-local
?) to offer current latest channel. One other alternative is to keep publishing latest as it is but default to beta-4. I can change the PR to that approach as well according to comments.