Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: testcontainers integration #386

Merged
merged 43 commits into from
Feb 14, 2025
Merged

feat: testcontainers integration #386

merged 43 commits into from
Feb 14, 2025

Conversation

viraj124
Copy link
Contributor

@viraj124 viraj124 commented Jan 24, 2025 •
edited
Loading

@viraj124 viraj124 requested a review from a team as a code owner January 24, 2025 07:40
@viraj124 viraj124 marked this pull request as draft January 24, 2025 11:12
@viraj124 viraj124 marked this pull request as ready for review January 27, 2025 11:03
DefiCake
DefiCake reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@DefiCake DefiCake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test CIs seem to be failing - commented through internal channels

DefiCake
DefiCake previously approved these changes Feb 13, 2025
View reviewed changes
PraneshASP
PraneshASP reviewed Feb 14, 2025
View reviewed changes
packages/integration-tests/tests/transfer_eth.ts Outdated
@@ -357,6 +362,7 @@ describe('Transferring ETH', async function () {
let ethereumETHReceiverAddress: string;
let withdrawMessageProof: MessageProof;
let rateLimitDuration: bigint;
// let fuel_signer2: FuelWallet;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

PraneshASP
PraneshASP reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@PraneshASP PraneshASP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, few nits.

@DefiCake DefiCake self-requested a review February 14, 2025 09:23
@viraj124 viraj124 merged commit bc02a46 into main Feb 14, 2025
10 checks passed
@viraj124 viraj124 deleted the viraj124/382-feat-testcontainers-integration branch February 14, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraneshASP PraneshASP PraneshASP approved these changes

@DefiCake DefiCake DefiCake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(test): switch to testcontainers for integration tests
3 participants
@viraj124 @PraneshASP @DefiCake