Fix creation of dynamic property in core/flarum DispatchEventsTrait #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84 #85
Changes proposed in this pull request:
Just renamed
$user
field of this event to$actor
, because core/flarum DispatchEventsTrait trying to write->actor
field, which is not exists and php8.1+ fails because of deprecation errorReviewers should focus on:
seems to
WillReactToPost::$actor
is not reading or writing outside of the class.maybe we should prefer getter methods instead of direct field access?
Screenshot
dont have any
Confirmed
Frontend changes: tested on a local Flarum installation.
Backend changes: tests are green (run
composer test
).Tested it right on production by applying this path directly to vendor dir and liked a random post :3
Required changes: