Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Frontend Extenders, Switch to yarn & Basic TS Refactor #124

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Use Frontend Extenders, Switch to yarn & Basic TS Refactor #124

merged 7 commits into from
Oct 17, 2024

Conversation

DavideIadeluca
Copy link
Member

Fixes #0000

Changes proposed in this pull request:

  • Switch to yarn
  • Use frontend extenders
  • Basic TS Refactor
  • Add shims

Reviewers should focus on:

  • Should we eventually register the vote model to the store and make it type safe as well? For internal typings, I didn't type upvotes and downvotes at all. For external use (shims) I added the unknown type.

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@DavideIadeluca DavideIadeluca added the enhancement New feature or request label Oct 5, 2024
@DavideIadeluca DavideIadeluca self-assigned this Oct 5, 2024
@DavideIadeluca DavideIadeluca merged commit 6f76631 into master Oct 17, 2024
32 checks passed
@DavideIadeluca DavideIadeluca deleted the di/frontend-refactor branch October 17, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees

@DavideIadeluca DavideIadeluca

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideIadeluca @imorland