-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Multimedia package base on 6.6.52 #2055
base: master
Are you sure you want to change the base?
Upgrade Multimedia package base on 6.6.52 #2055
Conversation
I would like to clarify a comment I made earlier. It would be beneficial to improve the comments in each commit log. Specifically, I suggest describing the individual changes made to each recipe within their respective commit logs. This detailed documentation will be useful for referencing the reasons behind each change in the future. |
876ea2c
to
bf8e076
Compare
recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.7.imx.bb
Outdated
Show resolved
Hide resolved
recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.7.imx.bb
Outdated
Show resolved
Hide resolved
recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.24.7.imx.bb
Outdated
Show resolved
Hide resolved
recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.24.7.imx.bb
Outdated
Show resolved
Hide resolved
2049471
to
671393d
Compare
recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.24.7.imx.bb
Outdated
Show resolved
Hide resolved
recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.7.imx.bb
Outdated
Show resolved
Hide resolved
671393d
to
73aec8c
Compare
Please rebase this pull request because I made the change to remove the checksum across all the files to a single commit. So you will need also to remove this from this and other pull requests. |
73aec8c
to
b45e4fc
Compare
44d3478
to
ee407ee
Compare
recipes-multimedia/alsa/alsa-lib/0001-pcm-dmix-Fix-resume-with-multiple-instances.patch
Outdated
Show resolved
Hide resolved
@@ -20,7 +20,7 @@ inherit autotools pkgconfig use-imx-headers | |||
PV = "1.0.26+${SRCPV}" | |||
|
|||
SRC_URI = "git://github.com/nxp-imx/imx-alsa-plugins.git;protocol=https;branch=${SRCBRANCH}" | |||
SRCBRANCH = "MM_04.09.01_2408_L6.6.y" | |||
SRCBRANCH = "MM_04.09.02_2410_L6.6.y" | |||
SRCREV = "b2ba082e70333f187972ee4e85f63f9d2f608331" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the branch changes but the SRCREV does not change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zelan-nxp Please see the @angolini comments.
recipes-multimedia/alsa/alsa-lib/0001-pcm-dmix-Fix-resume-with-multiple-instances.patch
Outdated
Show resolved
Hide resolved
ee407ee
to
1cfd68b
Compare
Signed-off-by: Zelan Zou <[email protected]>
Bump version 2.1.8 -> 2.1.9 License update to EULA V58 Signed-off-by: Zelan Zou <[email protected]>
Bump version 0.5.0 -> 0.6.0 Signed-off-by: Zelan Zou <[email protected]>
Bump version 4.9.1 -> 4.9.2 Signed-off-by: Zelan Zou <[email protected]>
Signed-off-by: Zelan Zou <[email protected]>
1cfd68b
to
947b3eb
Compare
I noticed that some recipes have been dropped completely from the changes. For example, the gstreamer changes have not been included. Could you explain what are your plans about those changes? |
I split gstreamer change to another PR , it have merged. |
Sure, I noticed, but bear in mind that you didn't mention that in the changes, nor in the pull request. For example, the changes in the ALSA library, those have been dropped, but was not mentioned in the pull request, what are going to be done in those changes, or if they are not necessary anymore. As this pull request has touch many different areas, it got a little convoluted and difficult to track. Ideally, next time would be better if you could create separated pull requests for each individual set of recipes so we would reduce the number of changes and make it easier to follow. |
Upstream MM packages:
dsp: 2.1.8 -> 2.1.9
opencl-converter: 0.5.0 ->0.6.0
imx-parser: 4.9.1- >4.9.2
imx-vpuwrapper: drop unneeded patch