Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Multimedia package base on 6.6.52 #2055

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zelan-nxp
Copy link
Contributor

@zelan-nxp zelan-nxp commented Jan 7, 2025

Upstream MM packages:

dsp: 2.1.8 -> 2.1.9
opencl-converter: 0.5.0 ->0.6.0
imx-parser: 4.9.1- >4.9.2
imx-vpuwrapper: drop unneeded patch

recipes-multimedia/alsa/alsa-lib_%.bbappend Outdated Show resolved Hide resolved
@otavio
Copy link
Member

otavio commented Jan 7, 2025

I would like to clarify a comment I made earlier. It would be beneficial to improve the comments in each commit log. Specifically, I suggest describing the individual changes made to each recipe within their respective commit logs. This detailed documentation will be useful for referencing the reasons behind each change in the future.

@otavio otavio mentioned this pull request Jan 7, 2025
25 tasks
@zelan-nxp zelan-nxp force-pushed the multimedia-package-6.6.52 branch from 876ea2c to bf8e076 Compare January 8, 2025 09:49
@zelan-nxp zelan-nxp force-pushed the multimedia-package-6.6.52 branch 2 times, most recently from 2049471 to 671393d Compare January 9, 2025 11:11
@zelan-nxp zelan-nxp force-pushed the multimedia-package-6.6.52 branch from 671393d to 73aec8c Compare January 9, 2025 12:39
@otavio otavio self-requested a review January 13, 2025 20:14
@otavio
Copy link
Member

otavio commented Jan 13, 2025

Please rebase this pull request because I made the change to remove the checksum across all the files to a single commit. So you will need also to remove this from this and other pull requests.

@zelan-nxp zelan-nxp force-pushed the multimedia-package-6.6.52 branch from 73aec8c to b45e4fc Compare January 14, 2025 02:17
@zelan-nxp zelan-nxp force-pushed the multimedia-package-6.6.52 branch 2 times, most recently from 44d3478 to ee407ee Compare January 15, 2025 11:33
@@ -20,7 +20,7 @@ inherit autotools pkgconfig use-imx-headers
PV = "1.0.26+${SRCPV}"

SRC_URI = "git://github.com/nxp-imx/imx-alsa-plugins.git;protocol=https;branch=${SRCBRANCH}"
SRCBRANCH = "MM_04.09.01_2408_L6.6.y"
SRCBRANCH = "MM_04.09.02_2410_L6.6.y"
SRCREV = "b2ba082e70333f187972ee4e85f63f9d2f608331"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the branch changes but the SRCREV does not change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zelan-nxp Please see the @angolini comments.

recipes-multimedia/imx-dsp/imx-dsp_2.1.9.bb Show resolved Hide resolved
@zelan-nxp zelan-nxp force-pushed the multimedia-package-6.6.52 branch from ee407ee to 1cfd68b Compare February 7, 2025 10:08
Bump version 2.1.8 -> 2.1.9
License update to EULA V58

Signed-off-by: Zelan Zou <[email protected]>
Bump version 0.5.0 -> 0.6.0

Signed-off-by: Zelan Zou <[email protected]>
Bump version 4.9.1 -> 4.9.2

Signed-off-by: Zelan Zou <[email protected]>
@zelan-nxp zelan-nxp force-pushed the multimedia-package-6.6.52 branch from 1cfd68b to 947b3eb Compare February 8, 2025 06:46
@otavio
Copy link
Member

otavio commented Feb 10, 2025

I noticed that some recipes have been dropped completely from the changes. For example, the gstreamer changes have not been included. Could you explain what are your plans about those changes?

@zelan-nxp
Copy link
Contributor Author

I noticed that some recipes have been dropped completely from the changes. For example, the gstreamer changes have not been included. Could you explain what are your plans about those changes?

I split gstreamer change to another PR , it have merged.

@otavio
Copy link
Member

otavio commented Feb 10, 2025

Sure, I noticed, but bear in mind that you didn't mention that in the changes, nor in the pull request.

For example, the changes in the ALSA library, those have been dropped, but was not mentioned in the pull request, what are going to be done in those changes, or if they are not necessary anymore.

As this pull request has touch many different areas, it got a little convoluted and difficult to track. Ideally, next time would be better if you could create separated pull requests for each individual set of recipes so we would reduce the number of changes and make it easier to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants