Fix infinite loop causing memory leak in GH-1519 #1531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know the codebase/protocol well enough to know whether we can always expect there to be at least one value in the iterator, or whether we need to have a fallback and a check, e.g. head = next(iter(results), None)
if head is None:
break |
oroulet
reviewed
Dec 18, 2023
| @@ -450,6 +450,7 @@ async def _browse_next(self, results: Iterable[ua.BrowseResult]) -> List[ua.Refe | |||
| params.ContinuationPoints = [head.ContinuationPoint] | |||
| params.ReleaseContinuationPoints = False | |||
| results = await self.session.browse_next(params) | |||
| head = next(iter(results)) | |||
There was a problem hiding this comment.
yes we should check that next does not return None
oroulet
reviewed
Dec 18, 2023
| @@ -450,6 +450,7 @@ async def _browse_next(self, results: Iterable[ua.BrowseResult]) -> List[ua.Refe | |||
| params.ContinuationPoints = [head.ContinuationPoint] | |||
| params.ReleaseContinuationPoints = False | |||
| results = await self.session.browse_next(params) | |||
| head = next(iter(results)) | |||
There was a problem hiding this comment.
but something else i wrong here. The original code only handled results[0] and this is correct since we only sent one request to server. Now that check is gone...
oroulet
reviewed
Dec 18, 2023
| @@ -450,6 +450,7 @@ async def _browse_next(self, results: Iterable[ua.BrowseResult]) -> List[ua.Refe | |||
| params.ContinuationPoints = [head.ContinuationPoint] | |||
| params.ReleaseContinuationPoints = False | |||
| results = await self.session.browse_next(params) | |||
| head = next(iter(results)) | |||
There was a problem hiding this comment.
I propose we just revert to original code, I do not see anything wrong in it (apart from getting a strange error if result does not contain at least one result., it should but...)
|
Sounds good, @oroulet :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.