Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected]_py312: add new cmake args for linking on linux #654

Closed
wants to merge 3 commits into from
Closed

[email protected]_py312: add new cmake args for linking on linux #654

wants to merge 3 commits into from

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented Dec 22, 2024

[email protected]_py312: add new cmake args for linking on linux add new dep vtk 9.4

@ipatch
[email protected]_py312: add new cmake args for linking on linux
e25c2fd 
[email protected]_py312: add new cmake args for linking on linux add new dep vtk 9.4
@ipatch
Copy link
Collaborator Author

ipatch commented Dec 22, 2024

the recent update of vtk 9.4 definitely broke something. copy pasted from two workflow runs,

SMDS_UnstructuredGrid.cpp.o.d -o src/3rdParty/salomesmesh/CMakeFiles/SMDS.dir/src/SMDS/SMDS_UnstructuredGrid.cpp.o -c /tmp/freecadA1.0.0_py312-20241222-24708-magua8/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp
2024-12-22T04:55:48.9474628Z In file included from /tmp/freecadA1.0.0_py312-20241222-24708-magua8/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:20:
2024-12-22T04:55:48.9475268Z /tmp/freecadA1.0.0_py312-20241222-24708-magua8/FreeCAD-1.0.0/src/3rdParty/salomesmesh/inc/SMDS_UnstructuredGrid.hxx:99:39: warning: 'GetCellLinks' is deprecated: Use GetLinks() instead. [-Wdeprecated-declarations]
2024-12-22T04:55:48.9475400Z    99 |     return static_cast<vtkCellLinks*>(GetCellLinks());
2024-12-22T04:55:48.9475493Z       |                                       ^
2024-12-22T04:55:48.9475915Z /home/linuxbrew/.linuxbrew/opt/vtk/include/vtk-9.4/vtkUnstructuredGrid.h:248:3: note: 'GetCellLinks' has been explicitly marked deprecated here
2024-12-22T04:55:48.9476036Z   248 |   VTK_DEPRECATED_IN_9_3_0("Use GetLinks() instead.")
2024-12-22T04:55:48.9476107Z       |   ^
2024-12-22T04:55:48.9476459Z /home/linuxbrew/.linuxbrew/opt/vtk/include/vtk-9.4/vtkDeprecation.h:116:41: note: expanded from macro 'VTK_DEPRECATED_IN_9_3_0'
2024-12-22T04:55:48.9476611Z   116 | #define VTK_DEPRECATED_IN_9_3_0(reason) VTK_DEPRECATION(reason)
2024-12-22T04:55:48.9476696Z       |                                         ^
2024-12-22T04:55:48.9477018Z /home/linuxbrew/.linuxbrew/opt/vtk/include/vtk-9.4/vtkDeprecation.h:88:48: note: expanded from macro 'VTK_DEPRECATION'
2024-12-22T04:55:48.9477192Z    88 | #define VTK_DEPRECATION(reason) __attribute__((__deprecated__(reason)))
2024-12-22T04:55:48.9477282Z       |                                                ^
2024-12-22T04:55:48.9477820Z /tmp/freecadA1.0.0_py312-20241222-24708-magua8/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:268:54: error: no member named 'GetValue' in 'vtkCellArray'
2024-12-22T04:55:48.9477954Z   268 |                int oldFaceLoc = this->FaceLocations->GetValue(i);
2024-12-22T04:55:48.9478035Z       |                                 ~~~~~~~~~~~~~~~~~~~~~^
2024-12-22T04:55:48.9478555Z /tmp/freecadA1.0.0_py312-20241222-24708-magua8/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:269:46: error: no member named 'GetValue' in 'vtkCellArray'
2024-12-22T04:55:48.9478691Z   269 |                int nCellFaces = this->Faces->GetValue(oldFaceLoc++);
2024-12-22T04:55:48.9478771Z       |                                 ~~~~~~~~~~~~~^
2024-12-22T04:55:48.9479291Z /tmp/freecadA1.0.0_py312-20241222-24708-magua8/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:273:50: error: no member named 'GetValue' in 'vtkCellArray'
2024-12-22T04:55:48.9479426Z   273 |                    int nptsInFace = this->Faces->GetValue(oldFaceLoc++);
2024-12-22T04:55:48.9479503Z       |                                     ~~~~~~~~~~~~~^
2024-12-22T04:55:48.9480020Z /tmp/freecadA1.0.0_py312-20241222-24708-magua8/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:277:49: error: no member named 'GetValue' in 'vtkCellArray'
2024-12-22T04:55:48.9480138Z   277 |                        int oldpt = this->Faces->GetValue(oldFaceLoc++);
2024-12-22T04:55:48.9480215Z       |                                    ~~~~~~~~~~~~~^
2024-12-22T04:55:48.9480757Z /tmp/freecadA1.0.0_py312-20241222-24708-magua8/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:295:11: error: no matching member function for call to 'SetCells'
2024-12-22T04:55:48.9480973Z   295 |     this->SetCells(newTypes, newLocations, newConnectivity, FaceLocations, Faces);
2024-12-22T04:55:48.9481043Z       |     ~~~~~~^~~~~~~~
2024-12-22T04:55:48.9481873Z /home/linuxbrew/.linuxbrew/opt/vtk/include/vtk-9.4/vtkUnstructuredGrid.h:539:8: note: candidate function not viable: no known conversion from 'vtkSmartPointer<vtkCellArray>' to 'vtkIdTypeArray *' for 4th argument
2024-12-22T04:55:48.9482151Z   539 |   void SetCells(vtkUnsignedCharArray* cellTypes, vtkIdTypeArray* cellLocations, vtkCellArray* cells,
2024-12-22T04:55:48.9482220Z       |        ^
2024-12-22T04:55:48.9482360Z   540 |     vtkIdTypeArray* faceLocations, vtkIdTypeArray* faces);
2024-12-22T04:55:48.9482431Z       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

2024-12-22T04:09:05.5778690Z /opt/homebrew/opt/vtk/include/vtk-9.4/vtkDeprecation.h:88:48: note: expanded from macro 'VTK_DEPRECATION'
2024-12-22T04:09:05.5778840Z #define VTK_DEPRECATION(reason) __attribute__((__deprecated__(reason)))
2024-12-22T04:09:05.5778920Z                                                ^
2024-12-22T04:09:05.5779340Z /tmp/freecadA1.0.0_py312-20241222-21207-bjw4i3/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:268:54: error: no member named 'GetValue' in 'vtkCellArray'
2024-12-22T04:09:05.5779440Z                int oldFaceLoc = this->FaceLocations->GetValue(i);
2024-12-22T04:09:05.5779500Z                                 ~~~~~~~~~~~~~~~~~~~~~^
2024-12-22T04:09:05.5779910Z /tmp/freecadA1.0.0_py312-20241222-21207-bjw4i3/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:269:46: error: no member named 'GetValue' in 'vtkCellArray'
2024-12-22T04:09:05.5780010Z                int nCellFaces = this->Faces->GetValue(oldFaceLoc++);
2024-12-22T04:09:05.5780070Z                                 ~~~~~~~~~~~~~^
2024-12-22T04:09:05.5780480Z /tmp/freecadA1.0.0_py312-20241222-21207-bjw4i3/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:273:50: error: no member named 'GetValue' in 'vtkCellArray'
2024-12-22T04:09:05.5780580Z                    int nptsInFace = this->Faces->GetValue(oldFaceLoc++);
2024-12-22T04:09:05.5780640Z                                     ~~~~~~~~~~~~~^
2024-12-22T04:09:05.5781050Z /tmp/freecadA1.0.0_py312-20241222-21207-bjw4i3/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:277:49: error: no member named 'GetValue' in 'vtkCellArray'
2024-12-22T04:09:05.5781140Z                        int oldpt = this->Faces->GetValue(oldFaceLoc++);
2024-12-22T04:09:05.5781200Z                                    ~~~~~~~~~~~~~^
2024-12-22T04:09:05.5781630Z /tmp/freecadA1.0.0_py312-20241222-21207-bjw4i3/FreeCAD-1.0.0/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:295:11: error: no matching member function for call to 'SetCells'
2024-12-22T04:09:05.5781790Z     this->SetCells(newTypes, newLocations, newConnectivity, FaceLocations, Faces);
2024-12-22T04:09:05.5781830Z     ~~~~~~^~~~~~~~
2024-12-22T04:09:05.5782520Z /opt/homebrew/opt/vtk/include/vtk-9.4/vtkUnstructuredGrid.h:539:8: note: candidate function not viable: no known conversion from 'vtkSmartPointer<vtkCellArray>' to 'vtkIdTypeArray *' for 4th argument
2024-12-22T04:09:05.5782790Z   void SetCells(vtkUnsignedCharArray* cellTypes, vtkIdTypeArray* cellLocations, vtkCellArray* cells,
2024-12-22T04:09:05.5782840Z        ^
2024-12-22T04:09:05.5783190Z /opt/homebrew/opt/vtk/include/vtk-9.4/vtkUnstructuredGrid.h:289:8: note: candidate function not viable: requires 4 arguments, but 5 were provided
2024-12-22T04:09:05.5783540Z   void SetCells(vtkUnsignedCharArray* cellTypes, vtkCellArray* cells, vtkIdTypeArray* faceLocations,

@ipatch
Copy link
Collaborator Author

ipatch commented Dec 22, 2024

from upstream freecad repo

FreeCAD/FreeCAD#18423

@ipatch ipatch self-assigned this Dec 22, 2024
@ipatch ipatch added pr-pull and removed pr-pull labels Dec 22, 2024
github-actions bot pushed a commit that referenced this pull request Dec 22, 2024
@ipatch
fix sha256sum mismatch for patch file
e0c01cf 
Closes #654.

Signed-off-by: Chris <[email protected]>
@ipatch ipatch closed this Dec 22, 2024
This was referenced Dec 22, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ipatch ipatch

Labels
pr-pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ipatch