Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]_rc2_py312: rm ref to shiboken2 #586

Closed

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented Oct 22, 2024

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch
Copy link
Collaborator Author

ipatch commented Oct 22, 2024

==> Running Formulae#formula!(freecad/freecad/[email protected]_rc2_py312)
==> brew deps --tree --annotate --include-build --include-test freecad/freecad/[email protected]_rc2_py312
Warning: [email protected]_rc2_py312 has unbottled dependencies, so a bottle will not be built.
==> SKIPPED freecad/freecad/[email protected]_rc2_py312
Warning: No bottle built.

@ipatch
Copy link
Collaborator Author

ipatch commented Oct 22, 2024

the below formula in the tap will require rebottling for Sequoia

@ipatch ipatch self-assigned this Oct 24, 2024
@ipatch ipatch added the pr-pull label Oct 24, 2024
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
@ipatch
Copy link
Collaborator Author

ipatch commented Oct 24, 2024

PR pull merged these changes, so no need to rebase and merge here.

@ipatch ipatch closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant