Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename localNameOnly to doNotPrependNamespace #1993

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Jan 27, 2025

This PR fixes #1963

Copy link
Contributor

@maximiliankaul maximiliankaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oxisto oxisto enabled auto-merge (squash) January 28, 2025 12:00
@oxisto oxisto force-pushed the doNotPrependNamespace branch from 5970d32 to 9103cb5 Compare January 28, 2025 12:27
@oxisto oxisto merged commit 607f345 into main Jan 28, 2025
2 checks passed
@oxisto oxisto deleted the doNotPrependNamespace branch January 28, 2025 12:41
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (d031b38) to head (9103cb5).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
...e/fraunhofer/aisec/cpg/graph/DeclarationBuilder.kt 94.63% <100.00%> (ø)
...otlin/de/fraunhofer/aisec/cpg/graph/NodeBuilder.kt 74.54% <100.00%> (+1.81%) ⬆️
...otlin/de/fraunhofer/aisec/cpg/graph/TypeBuilder.kt 53.84% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oxisto added a commit that referenced this pull request Jan 28, 2025
* Rename `localNameOnly` to `doNotPrependNamespace`

This PR fixes #1963

* spotless

---------

Co-authored-by: Maximilian Kaul <[email protected]>
oxisto added a commit that referenced this pull request Jan 29, 2025
* Rename `localNameOnly` to `doNotPrependNamespace`

This PR fixes #1963

* spotless

---------

Co-authored-by: Maximilian Kaul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better name for localNameOnly in applyMetadata
2 participants