ResolveMemberExpressionAmbiguityPass now correctly set an FQN in its replaced references
#1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
requested review from
konradweiss,
KuechA,
maximiliankaul and
lshala
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
maximiliankaul
approved these changes
Jan 30, 2025
…s replaced references Previously, we were re-using the (partial) name of the expression instead of the FQN. This has led to some unexpected results, in a way that later passes could not resolve the type of the reference (or call expression).
oxisto
force-pushed
the
fqn-resolve-member-expression
branch
from
4723cc8 to
b247467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were re-using the (partial) name of the expression instead of the FQN. This has led to some unexpected results, in a way that later passes could not resolve the type of the reference (or call expression).