-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified and more basic fixpoint iteration #1810
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Some smaller documentation issues and maybe we can avoid some of the result order comparisons.
The current fix-point iteration system is a bit tricky to understand and hard to debug. I'd try to remove some of the bloat and simplify it. In particular, it should keep less states (i.e., save memory, remove a bunch of indirections) and copy objects instead of manipulating them (which should make it easier to understand things).