Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified and more basic fixpoint iteration #1810

Merged
merged 58 commits into from
Feb 5, 2025
Merged

Simplified and more basic fixpoint iteration #1810

merged 58 commits into from
Feb 5, 2025

Conversation

KuechA
Copy link
Contributor

@KuechA KuechA commented Nov 5, 2024

The current fix-point iteration system is a bit tricky to understand and hard to debug. I'd try to remove some of the bloat and simplify it. In particular, it should keep less states (i.e., save memory, remove a bunch of indirections) and copy objects instead of manipulating them (which should make it easier to understand things).

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 80.10753% with 37 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (3236e15) to head (437f9d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ec/cpg/helpers/functional/BasicLatticesRedesign.kt 79.88% 30 Missing and 6 partials ⚠️
...lin/de/fraunhofer/aisec/cpg/helpers/IdentitySet.kt 85.71% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
.../fraunhofer/aisec/cpg/passes/UnreachableEOGPass.kt 89.47% <ø> (ø)
...lin/de/fraunhofer/aisec/cpg/helpers/IdentitySet.kt 95.12% <85.71%> (+7.02%) ⬆️
...ec/cpg/helpers/functional/BasicLatticesRedesign.kt 79.88% <79.88%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KuechA KuechA marked this pull request as ready for review January 22, 2025 13:39
@KuechA KuechA requested a review from konradweiss as a code owner January 22, 2025 13:39
Copy link
Member

@oxisto oxisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Some smaller documentation issues and maybe we can avoid some of the result order comparisons.

@KuechA KuechA merged commit dbf050d into main Feb 5, 2025
4 checks passed
@KuechA KuechA deleted the ak/fixpointv2 branch February 5, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants