Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging Campaign experimental into the Public version #37

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

Fragjacker
Copy link
Owner

@Fragjacker Fragjacker commented Aug 11, 2022

Description

This request adds the experimental features of the DLL injector functionality developed by @AndO3131 into the public branch.

TODO

  • Check the Pull locally and see if no functionality has been overwritten.
  • Make sure the app will update properly.
  • Add some kind of safety mechanism in case the DLL file does not locally exist on the recipients machine.
    • Either do an auto downloader functionality. (harder solution)
      OR
    • Simply deactivate the checkbox if the file does not exist. (easiest solution)

AndO3131 added 30 commits May 3, 2021 15:16
Dialog box with messages pops up to inform how it's going.
And some tests overwriting soulstorm.exe memory
…reateProcessWithDllEx' function is not found inside UNI_EXT.DLL library
More tries at animation loading function.
@Fragjacker Fragjacker self-assigned this Aug 11, 2022
@AndO3131
Copy link

I haven't checked update functionality, but I think other functions work properly.

Copy link

@AndO3131 AndO3131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've compiled both program and library. They seem to work correctly.

Copy link
Owner Author

@Fragjacker Fragjacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's reports that the Fog Remover is not working reliably on this version. I cannot imagine that your changes to FogRemover.cs file alone are the culprit. Could it be that the DLL injection is messing with the way this is written to game memory?

@AndO3131
Copy link

Regarding FogRemover.cs I only added two "int" keywords. Otherwise this file didn't compile. I highly doubt that could be the cause of anything.

About DLL injection messing with memory, that's another story. I honestly don't know. Newer had any issues with fog using injection (which I use almost all the time).

@AndO3131
Copy link

One behaviour has been solved: mod manager should no longer reset settings on mods. It was caused by additional "."(dot) in unification campaign addon folder and module file, so unrelated to mod manager code.

@Fragjacker
Copy link
Owner Author

Alright now there's another pull-request up for updating the Mod Manager. Now there's the question which request should come first either way one would need to get updated anyways. Is this request still solid and ready for production?

@AndO3131
Copy link

I didn't make any changes since august in this branch. I've compiled mod manager and corresponding UNI_EXT.DLL today and it loads correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants