wstETH-wETH-vault-oracle #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyonline
reviewed
Jul 9, 2023
| @@ -39,7 +39,7 @@ contract BaseOracle is AggregatorV3Interface { | |||
|
|
|||
| bool public isCheckPriceDeviation; | |||
|
|
|||
| uint256 constant internal DECIMAL_DIFFERENCE = 1e6; | |||
| uint256 constant internal DECIMAL_DIFFERENCE = 1e10; | |||
There was a problem hiding this comment.
can you pls explain this change?
johnnyonline
reviewed
Jul 9, 2023
|
|
||
| /// @notice Triggers the Vault's reentrancy guard | ||
| /// @dev This staticcall always reverts, but we need to make sure it doesn't fail due to a re-entrancy attack (abi.encoded BAL#400). | ||
| modifier reentrancyCheck() { |
There was a problem hiding this comment.
can you also explain this please
|
@johnnyonline take a look at Balancer docs |
| /********************************** Internal Functions **********************************/ | ||
|
|
||
| function _getPrice() internal view override returns (int256) { | ||
| function _getPrice() internal reentrancyCheck returns (int256) { | ||
| uint256 rate = BPT.getRate(); | ||
| if (rate < 1*1e18 || rate >= 1.1*1e18) revert virtualPriceOutOfBounds(); |
There was a problem hiding this comment.
perhaps the bounds should not be hardcoded, and give owner ability to change them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.balancer.fi/concepts/advanced/valuing-bpt/valuing-bpt.html#informational-price-evaluation