Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy tides inequality, convergence robustness, docs #326

Merged
merged 11 commits into from
Jan 21, 2025
Merged

Conversation

nichollsh
Copy link
Contributor

@nichollsh nichollsh commented Jan 20, 2025

  • Allow setting dummy tidal heating with an inequality so that we can represent dummy solid or liquid phase tides. E.g. phi < 0.3, phi > 0.8.
  • Moved rheological transition location and width variables into config file.
  • Update citation info
  • Update termination criteria. They must be satisfied for two sequential iterations in order for the model to exit, otherwise the model can spuriously exit if it briefly satisfies the criteria while moving past them, which is not a physically justifiable point at which to terminate. Exception to this is atmospheric escape, which only needs to be satisfied for a single iteration.
  • Updated physical test. New convergence criteria mean that it does 1 extra iteration.

@nichollsh nichollsh marked this pull request as ready for review January 20, 2025 12:17
Copy link
Contributor

@planetmariana planetmariana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition for the tides looks nice, thanks @nichollsh

@planetmariana planetmariana merged commit c089723 into main Jan 21, 2025
5 checks passed
@planetmariana planetmariana deleted the hn/tideineq branch January 21, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants