Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up automated tests via Github Actions #128

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Set up automated tests via Github Actions #128

merged 9 commits into from
Aug 8, 2024

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Aug 7, 2024

This PR sets up the boilerplate for automated tests on github. To avoid unnecessary tests (e.g. when the PR is not ready yet), I set it up so that the tests run after "Ready for review".

To run the tests locally: pytest
For now there is just a dummy hello_world function until we start to populate the proteus module.

I renamed proteus.py -> start_proteus.py to avoid a name collission with the module.

Closes #86

@stefsmeets stefsmeets marked this pull request as ready for review August 7, 2024 08:55
@stefsmeets
Copy link
Contributor Author

@timlichtenberg

@stefsmeets
Copy link
Contributor Author

@nichollsh This PR is ready, could you have a look at it?

@stefsmeets stefsmeets requested a review from nichollsh August 7, 2024 09:28
@timlichtenberg timlichtenberg self-requested a review August 7, 2024 09:28
@stefsmeets
Copy link
Contributor Author

Snuck in a coverage badge while I have admin rights 😅

@timlichtenberg
Copy link
Member

timlichtenberg commented Aug 7, 2024

Currently the PROTEUS logo is not displayed correctly on the main Github page. Do you also want to fix this while at it?
EDIT: I see this is included in another PR.

Copy link
Contributor

@nichollsh nichollsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start! It will be extremely useful to have some tests in PROTEUS, particularly as we transition to the new code structure.

@stefsmeets stefsmeets merged commit 6f4d97b into master Aug 8, 2024
1 check passed
@stefsmeets stefsmeets deleted the pytest branch August 8, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up automated tests via Github Actions
3 participants