SDKS-3533 Prevent duplicated notification on iOS SDK #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoareis
requested review from
spetrov,
vahancouver and
george-bafaloukas-forgerock
| FRALog.v("PushNotification object is created and saved into StorageClient") | ||
| } | ||
| else { | ||
| FRALog.w("PushNotification object failed to be stored into StorageClient") |
There was a problem hiding this comment.
Should we not treat that as an error and return nil? If we end up on this situation, is the Push actionable or would the app be stuck?
There was a problem hiding this comment.
Is there a valid reason that the notification will fail the storage step?
There was a problem hiding this comment.
good catch! we should return nil here. It's unlikely we will have an exception while persisting it because the default storage is the Keychain. However, if a developer decide to use SQLite or any other storage, it may happen, so we need to confirm
george-bafaloukas-forgerock
approved these changes
Dec 16, 2024
vahancouver
approved these changes
Dec 18, 2024
jeyanthanperiyasamy
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-3533 [iOS][Authenticator] Prevent duplicated notification on iOS SDK
Description
The iOS SDK does not verify whether a push notification with an identical identifier has already been stored, delegating this responsibility to the application developer. This PR include the following changes:
getNotificationByMessageIdmethod to theStorageClientandFRAClientFRAPushHandlerclass to check whether a payload was already persistedDefinition of Done Checklist: