Allowing DeviceBinding NONE option on Simulators

[george-bafaloukas-forgerock]

Allowing DeviceBinding NONE option on Simulators

Definition of Done Checklist:

• Acceptance criteria is met.
• All tasks listed in the user story have been completed.
• Coded to standards.
• Ensure backward compatibility.
• API reference docs is updated.
• Unit tests are written.
• Integration tests are written.
• e2e tests are written.
• Functional spec is written/updated.
• Example code snippets have been added.
• Change log updated.
• Documentation story is created and tracked.
• Tech debts and remaining tasks are tracked in separated ticket(s).

[jeyanthanperiyasamy]

can we add some tests for this?

[george-bafaloukas-forgerock]

Tests were failing and fixed based on that

[jeyanthanperiyasamy]

sorry didnt notice this test class update, when I add my comment, and at the same time u pushed.

[jeyanthanperiyasamy]

add some tests for this

[george-bafaloukas-forgerock]

Tests were failing and fixed based on that

[vahancouver]

Looks good to me, but there are still tests failing.

Failing tests:

DeviceBindingCallbackTests.test_21_execute_fail_timeout()
DeviceSigningVerifierCallbackTests.test_20_execute_fail_timeout()
DeviceSigningVerifierCallbackTests.test_20_execute_single_success_with_invalid_custom_claims()
DeviceSigningVerifierCallbackTests.test_23_sign_CustomDeviceAuthenticatorCustomClaimsAlwaysInvalid()

There are two more tests failing for recaptcha but they are not related to your change.
If u wanna fix them here too, u can replace
XCTAssertEqual(textOutputCallback.message, "\"VALIDATION_ERROR:CAPTCHA validation failed\"")
with XCTAssertTrue(textOutputCallback.message.contains("VALIDATION_ERROR:CAPTCHA validation failed"))

and replace
XCTAssertEqual(textOutputCallback.message, "\"CLIENT_ERROR:CUSTOM_CLIENT_ERROR\"")
with XCTAssertTrue(textOutputCallback.message.contains("CLIENT_ERROR:CUSTOM_CLIENT_ERROR"))

[george-bafaloukas-forgerock]

Looks good to me, but there are still tests failing.

Failing tests:

DeviceBindingCallbackTests.test_21_execute_fail_timeout()
DeviceSigningVerifierCallbackTests.test_20_execute_fail_timeout()
DeviceSigningVerifierCallbackTests.test_20_execute_single_success_with_invalid_custom_claims()
DeviceSigningVerifierCallbackTests.test_23_sign_CustomDeviceAuthenticatorCustomClaimsAlwaysInvalid()

There are two more tests failing for recaptcha but they are not related to your change. If u wanna fix them here too, u can replace XCTAssertEqual(textOutputCallback.message, "\"VALIDATION_ERROR:CAPTCHA validation failed\"") with XCTAssertTrue(textOutputCallback.message.contains("VALIDATION_ERROR:CAPTCHA validation failed"))

and replace XCTAssertEqual(textOutputCallback.message, "\"CLIENT_ERROR:CUSTOM_CLIENT_ERROR\"") with XCTAssertTrue(textOutputCallback.message.contains("CLIENT_ERROR:CUSTOM_CLIENT_ERROR"))

Damn I thought I fixed those. Will have a look. I'll leave the recaptcha ones to avoid any merge conflicts