Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #pragma pinvoke #550

Merged
merged 11 commits into from
Mar 2, 2024
Merged

Add #pragma pinvoke #550

merged 11 commits into from
Mar 2, 2024

Conversation

BadRyuner
Copy link
Contributor

@BadRyuner BadRyuner commented Feb 28, 2024

Yes, this is not a good implementation of "#pragma pinvoke"... (#511)
Some methods I didn't name correctly, hope for some help with that!

But it's working just fine.

@BadRyuner
Copy link
Contributor Author

Need a good example of a pinvoke function call that is on all three platforms in the same library... On Windows "puts" function in mscvrt, on Linux "puts" function in libc...

@ForNeVeR ForNeVeR self-requested a review February 28, 2024 12:55
@ForNeVeR ForNeVeR self-assigned this Feb 28, 2024
@BadRyuner
Copy link
Contributor Author

Well, the tests passed.

Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I've left some comments and ready to discuss minor issues.

Cesium.Ast/ExternalDeclarations.cs Outdated Show resolved Hide resolved
Cesium.CodeGen.Tests/CodeGenPinvokeTests.cs Outdated Show resolved Hide resolved
Cesium.CodeGen/Contexts/BlockScope.cs Outdated Show resolved Hide resolved
Cesium.CodeGen/Contexts/GlobalConstructorScope.cs Outdated Show resolved Hide resolved
Cesium.CodeGen/Contexts/IDeclarationScope.cs Outdated Show resolved Hide resolved
Cesium.CodeGen/Contexts/Meta/FunctionInfo.cs Outdated Show resolved Hide resolved
Cesium.CodeGen/Ir/BlockItems/PinvokeDefinition.cs Outdated Show resolved Hide resolved
Cesium.Preprocessor/CPreprocessor.cs Outdated Show resolved Hide resolved
Cesium.Preprocessor/CPreprocessor.cs Outdated Show resolved Hide resolved
@ForNeVeR ForNeVeR assigned BadRyuner and unassigned ForNeVeR Mar 1, 2024
@BadRyuner BadRyuner requested a review from ForNeVeR March 2, 2024 07:36
@ForNeVeR ForNeVeR assigned ForNeVeR and unassigned BadRyuner Mar 2, 2024
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit c97f912 into ForNeVeR:main Mar 2, 2024
3 checks passed
@BadRyuner BadRyuner deleted the pinvoke branch March 21, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants