Merge pull request #161 from Flutterwave/dev

Pull changes from dev
Flutterwave · Sep 10, 2024 · 07e98fe · 07e98fe
2 parents 89dafcc + 15ba877
commit 07e98fe
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,9 @@
 # Changelog
+## 1.1.11 | 2024-09-10
+Updated the `account_bank` field in all schema's.
+
+### Version Changes
+- [FIXED] Update validation (minLength & maxLength) for 'account_bank" parameter in the schema's.
 
 ## 1.1.10 | 2024-04-04
 Updated the variable name "package" which happens to be a reserved word in JavaScript, and it is causing compatibility issues with certain bundlers.

diff --git a/services/schema/auxillary.js b/services/schema/auxillary.js
@@ -85,7 +85,7 @@ const orderSchema = joi.object({
 
 // resolve account details
 const resolveSchema = joi.object({
-  account_bank: joi.string().length(3).required(),
+  account_bank: joi.string().min(3).max(11).required(),
   account_number: joi.string().required(),
   country: joi.string().uppercase().length(2).default('NG'),
   type: joi.string(),

diff --git a/services/schema/base.js b/services/schema/base.js
@@ -24,7 +24,7 @@ const listSchema = joi.object({
     .string()
     .max(20)
     .valid('daily', 'weekly', 'monthly', 'quarterly', 'yearly'),
-  account_bank: joi.string().length(3),
+  account_bank: joi.string().min(3).max(11).required(),
   account_number: joi.string().trim().max(20),
   bank_name: joi.string().trim().max(100),
   split_value: joi.number().min(0).max(1),

diff --git a/services/schema/create.js b/services/schema/create.js
@@ -52,7 +52,7 @@ const bankChargeSchema = joi.object({
 // create a beneficiary
 const beneficiarySchema = joi.object({
   account_number: joi.string().required(),
-  account_bank: joi.string().required(),
+  account_bank: joi.string().min(3).max(11).required(),
   beneficiary_name: joi.string().required(),
   currency: joi.string().uppercase().length(3),
   bank_name: joi.string(),
@@ -413,7 +413,7 @@ const refundSchema = joi.object({
 
 // create a subaccount
 const subaccountSchema = joi.object({
-  account_bank: joi.string().min(3).max(6).required(),
+  account_bank: joi.string().min(3).max(11).required(),
   account_number: joi.string().trim().max(20).required(),
   business_name: joi.string().trim().max(100).required(),
   split_value: joi.number().min(0).max(1).required(),
@@ -637,7 +637,7 @@ const tokenSchema = joi.object({
 
 // charge bank accounts: base for USSD charge
 const ussdChargeSchema = joi.object({
-  account_bank: joi.string().min(3).max(6).required(),
+  account_bank: joi.string().min(3).max(11).required(),
   amount: joi.number().positive().required(),
   email: joi.string().max(100).email().required(),
   tx_ref: joi.string().trim().max(100).required(),