添加新的音频引擎 miniaudio #2679
Open
添加新的音频引擎 miniaudio #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can it run on Mac or Linux? |
purerosefallen
requested changes
Feb 16, 2025
| auto name = BGMList[scene][bgm].c_str(); | ||
| wchar_t fname[1024]; | ||
| myswprintf(fname, L"./sound/BGM/%ls", name); | ||
| PlayMusic(reinterpret_cast<char*>(fname), false); |
There was a problem hiding this comment.
Use EncodeUTF8 rather than reinterpret_cast
| return; | ||
| ma_sound_uninit(&soundBGM); | ||
| #ifdef _WIN32 | ||
| ma_sound_init_from_file_w(&engineMusic, reinterpret_cast<wchar_t*>(song), MA_SOUND_FLAG_ASYNC | MA_SOUND_FLAG_STREAM, nullptr, nullptr, &soundBGM); |
There was a problem hiding this comment.
Also DecodeUTF8 here.
| @@ -177,6 +188,139 @@ void SoundManager::PlaySoundEffect(int sound) { | |||
| break; | |||
| } | |||
| #endif | |||
| #ifdef YGOPRO_USE_MINIAUDIO | |||
| @@ -25,6 +25,17 @@ bool SoundManager::Init() { | |||
| } | |||
| #endif // YGOPRO_USE_IRRKLANG | |||
| // TODO: Implement other sound engines | |||
| #ifdef YGOPRO_USE_MINIAUDIO | |||
| break; | ||
| } | ||
| case SOUND_COMMON_FEEDBACK: { | ||
| ma_engine_play_sound(&engineSound, "./sound/common_feedback.wav", nullptr); |
There was a problem hiding this comment.
Not used in YGOPro. Please remove it for now.
| BUILD_MINIAUDIO = false | ||
| end | ||
| if not BUILD_miniaudio then | ||
| MINIAUDIO_INCLUDE_DIR = GetParam("miniaudio-include-dir") or "/usr/local/include" |
There was a problem hiding this comment.
miniaudio being a single header library, everything in premake5.lua is not needed.
You may toss the miniaudio.h file to gframe directory directly. But remember to add some conditional checks in gframe/premake5.lua
|
哦，我晚点改，现在在写xmake。 |
I'm planning to use this one. Thanks for your work anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://miniaud.io/docs/manual/
有点疑虑
这里好像未经初始化就使用变量了，而我自己编译时往往带了-ftrivial-auto-var-init=zero，用于把变量自动初始化为0。
premake未测试……
大概没问题……